Summary: | [Qt] Use integer pixel metric QFont API to fix rounding errors in text rendering on the Mac | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Hausmann <hausmann> | ||||||||
Component: | Layout and Rendering | Assignee: | Simon Hausmann <hausmann> | ||||||||
Status: | CLOSED FIXED | ||||||||||
Severity: | Normal | CC: | allan.jensen, commit-queue, jesus, vestbo | ||||||||
Priority: | P3 | Keywords: | Qt | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Bug Depends on: | 93263 | ||||||||||
Bug Blocks: | 35784 | ||||||||||
Attachments: |
|
Description
Simon Hausmann
2010-03-24 06:55:47 PDT
Created attachment 51612 [details]
Turns off fractional metrics for fonts used in WebKit, since WebKit expects font engine to be integer-based
Compiles against Qt 4.7 as soon as the Oslo2 staging branch integrates.
I'll land this when the required changes in Qt have been integrated from oslo-staging-2 I think that oslo-staging-2 was integrated recently. Has this been landed yet? Created attachment 53250 [details]
Patch
Created attachment 53251 [details]
Patch
Comment on attachment 53251 [details] Patch Clearing flags on attachment: 53251 Committed r57516: <http://trac.webkit.org/changeset/57516> All reviewed patches have been landed. Closing bug. Revision r57516 cherry-picked into qtwebkit-2.0 with commit 692f59b5496489f88a49b4af6749b9b45df090ab I am not sure this hack is necesary. While WebKit still uses integer coordinates for layout (until we enable SUBPIXEL_LAYOUT). Text is not layed out using integers, but using floats. Or maybe the bug is that advances are being rounded when they shouldn't be? |