| Summary: | [Qt] Compilation error on Qt for Embedded Linux built with -qconfig large | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tasuku Suzuki <tasuku.suzuki> | ||||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | CLOSED FIXED | ||||||||||
| Severity: | Normal | CC: | chinmaya, commit-queue, hausmann | ||||||||
| Priority: | P2 | Keywords: | Qt | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | Linux | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 35784 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tasuku Suzuki
2010-03-24 05:44:38 PDT
Created attachment 51491 [details]
add #ifndef QT_NO_PROPERTIES ~ #endif
Created attachment 51492 [details]
add #ifndef QT_NO_ANIMATION ~ #endif
Comment on attachment 51491 [details]
add #ifndef QT_NO_PROPERTIES ~ #endif
Why? I don't understand why we want this change.
What is this intending to disable? If it's qt-specific, why are changes required to the common files?
+#ifndef QT_NO_PROPERTIES
PassScriptInstance createScriptInstanceForWidget(Widget*);
+#endif
Comment on attachment 51492 [details]
add #ifndef QT_NO_ANIMATION ~ #endif
Makes sense.
Created attachment 51611 [details]
add #ifndef QT_NO_PROPERTIES ~ #endif
This is a patch which exactly disables properties.
Comment on attachment 51492 [details] add #ifndef QT_NO_ANIMATION ~ #endif Clearing flags on attachment: 51492 Committed r56523: <http://trac.webkit.org/changeset/56523> Comment on attachment 51611 [details] add #ifndef QT_NO_PROPERTIES ~ #endif Clearning review as per https://bugs.webkit.org/show_bug.cgi?id=36529#c12 Comment on attachment 51611 [details] add #ifndef QT_NO_PROPERTIES ~ #endif Clearing flags on attachment: 51611 Committed r57334: <http://trac.webkit.org/changeset/57334> All reviewed patches have been landed. Closing bug. |