Bug 36486

Summary: Web Inspector: render nodes in inherited style bars as links.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change. timothy: review+

Pavel Feldman
Reported 2010-03-23 04:09:36 PDT
Also fixes few nits: - We no longer populate search field with the class name upon click on the selector. Rationale: selector text can't be usually found using plain text matching (comma separated values, ids, containment and such spoil it all and bring in confusion) - Sections are no longer collapsed upon href click - Breakpoints navigation is fixed
Attachments
[PATCH] Proposed change. (6.07 KB, patch)
2010-03-23 04:11 PDT, Pavel Feldman
timothy: review+
Pavel Feldman
Comment 1 2010-03-23 04:11:40 PDT
Created attachment 51411 [details] [PATCH] Proposed change.
Timothy Hatcher
Comment 2 2010-03-23 07:24:37 PDT
Comment on attachment 51411 [details] [PATCH] Proposed change. > + var nodeClass = styleRule.node.getAttribute("class"); > + if (nodeClass) > + title += "." + nodeClass; > + var nodeId = styleRule.node.getAttribute("id"); > + if (nodeId) > + title += "#" + nodeId; We should make this a helper function, I think we do this in another place when making a new style rule and breadcrumbs.
Pavel Feldman
Comment 3 2010-03-23 08:39:54 PDT
Landed with comments addressed (new utility function in elements panel). Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/BreakpointsSidebarPane.js M WebCore/inspector/front-end/ElementsPanel.js M WebCore/inspector/front-end/StylesSidebarPane.js M WebCore/inspector/front-end/inspector.js Committed r56395
Note You need to log in before you can comment on or make changes to this bug.