Bug 3644

Summary: Error string representation
Product: WebKit Reporter: Harri Porten <porten>
Component: JavaScriptCoreAssignee: Carsten Guenther <carsten>
Status: RESOLVED FIXED    
Severity: Minor    
Priority: P2    
Version: 412   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
One-line fix in error_object.cpp; updated expected.html
none
Updated patch including fixed layout tests
mjs: review+
Updated expected.html none

Harri Porten
Reported 2005-06-22 02:31:51 PDT
JSC regresses from the Mozilla string representation of Error objects. Use document.write(Error("test")) to see the difference. It's tiny but it unnecessarily breaks the tests in 15.11.1.1.js and 15.11.4.4-1.js in ecma_3/Exceptions of the Mozilla test suite. Just backed out from the JSC change I had applied on the weekend: http://websvn.kde.org/trunk/KDE/kdelibs/kjs/error_object.cpp?rev=427879&r1=426754&r2=427879
Attachments
One-line fix in error_object.cpp; updated expected.html (104.23 KB, patch)
2005-07-06 09:50 PDT, Carsten Guenther 		no flags
DetailsFormatted DiffDiff
Updated patch including fixed layout tests (110.72 KB, patch)
2005-07-06 10:34 PDT, Carsten Guenther 		mjs: review+
DetailsFormatted DiffDiff
Updated expected.html (108.94 KB, text/html)
2005-07-08 13:20 PDT, Carsten Guenther 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joost de Valk (AlthA)
Comment 1 2005-06-23 10:00:40 PDT
confirming this one.
Carsten Guenther
Comment 2 2005-07-06 09:50:20 PDT
Created attachment 2832 [details] One-line fix in error_object.cpp; updated expected.html
Carsten Guenther
Comment 3 2005-07-06 10:02:28 PDT
Comment on attachment 2832 [details] One-line fix in error_object.cpp; updated expected.html Cancelling. Needs to fix layout tests.
Carsten Guenther
Comment 4 2005-07-06 10:34:22 PDT
Created attachment 2833 [details] Updated patch including fixed layout tests
Maciej Stachowiak
Comment 5 2005-07-06 20:09:53 PDT
Comment on attachment 2833 [details] Updated patch including fixed layout tests r=me
Vicki Murley
Comment 6 2005-07-08 11:38:06 PDT
Carson, I'm trying to commit your fix but it looks like the patch program is getting confused. I suspect that lines in the updated test results that contain "-->" are to blame. Could you attach your updated test results? Thanks.
Carsten Guenther
Comment 7 2005-07-08 13:20:29 PDT
Created attachment 2869 [details] Updated expected.html Here it is.
Vicki Murley
Comment 8 2005-07-08 15:39:05 PDT
Silly me, I could have just generated my own expected.html file. At any rate, I've committed this fix.
Note You need to log in before you can comment on or make changes to this bug.