Bug 36437

Summary: executive.py: Refactor the cpu_count code
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
none
Proposed patch 2 none

Chris Jerdonek
Reported 2010-03-22 04:03:48 PDT
I noticed the several attempted imports of the multiprocessing module when debugging autoinstall: http://trac.webkit.org/changeset/53011/trunk/WebKitTools/Scripts/webkitpy/executive.py It might be nice to move the import statement to the top, and not use a try-catch construct.
Attachments
Proposed patch (2.05 KB, patch)
2010-03-22 04:21 PDT, Chris Jerdonek 		no flags
DetailsFormatted DiffDiff
Proposed patch 2 (1.89 KB, patch)
2010-03-22 06:20 PDT, Chris Jerdonek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-03-22 04:21:05 PDT
Created attachment 51273 [details] Proposed patch
Chris Jerdonek
Comment 2 2010-03-22 06:20:48 PDT
Created attachment 51279 [details] Proposed patch 2 On second thought, try-except is probably better in this case. Did you find that it was necessary to include NotImplementedError?
Adam Barth
Comment 3 2010-03-22 08:05:45 PDT
Comment on attachment 51279 [details] Proposed patch 2 Ok
WebKit Commit Bot
Comment 4 2010-03-22 09:24:41 PDT
Comment on attachment 51279 [details] Proposed patch 2 Clearing flags on attachment: 51279 Committed r56336: <http://trac.webkit.org/changeset/56336>
WebKit Commit Bot
Comment 5 2010-03-22 09:24:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.