Bug 36431

Summary: Clean up 'int' use in UString.cpp after r54789
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: New BugsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 34952    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch v2 darin: review+

David Kilzer (:ddkilzer)
Reported 2010-03-21 16:12:58 PDT
Created attachment 51258 [details] Patch Reviewed by NOBODY (OOPS!). * runtime/UString.cpp: (JSC::UString::from): Changed argument type from 'unsigned int' to 'unsigned' to match WebKit coding style. (JSC::UString::find): Changed static_cast<int>() to static_cast<unsigned>() now that this method returns unsigned. (JSC::UString::rfind): Ditto. --- 2 files changed, 19 insertions(+), 6 deletions(-)
Attachments
Patch (3.01 KB, patch)
2010-03-21 16:12 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (3.64 KB, patch)
2010-03-21 16:17 PDT, David Kilzer (:ddkilzer) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2010-03-21 16:17:23 PDT
Created attachment 51259 [details] Patch v2
David Kilzer (:ddkilzer)
Comment 2 2010-03-22 10:40:22 PDT
Committed r56342: <http://trac.webkit.org/changeset/56342>
Note You need to log in before you can comment on or make changes to this bug.