Summary: | InsertListCommand needs cleanup | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | enrica, eric, justin.garcia, ojan, tony | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 35281, 19539 | ||||||||
Bug Blocks: | 32422, 41403 | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2010-03-21 15:53:34 PDT
Created attachment 51386 [details]
first attempt to separate listifying/unlistifying code
This is my first attempt to separate two parts of doApply. Maybe it makes sense to file another but just to land this patch first. Svn diff is messy because it contains the changes to 19539 as well.
Seems like a good refactoring to me. The original method was long and the new function names help to clarify what the code is trying to do. Created attachment 57889 [details]
Isolates code for listifying/unlistifying paragraphs into seperate functions.
Comment on attachment 57889 [details]
Isolates code for listifying/unlistifying paragraphs into seperate functions.
r=me
Landed in http://trac.webkit.org/changeset/60877. |