Bug 36403

Summary: Undefined names in our python scripts
Product: WebKit Reporter: Holger Freyther <zecke>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposal of fixing some of the undefined names none

Holger Freyther
Reported 2010-03-19 20:02:15 PDT
These are all undefined names reported by pyflakes on the python code: ./changelogs.py:60: undefined name 'contents' ./bugzilla.py:85: undefined name 'patch' ./layout_tests/port/http_server.py:220: undefined name 'google' ./layout_tests/port/base.py:334: undefined name 'stat' ./layout_tests/port/base.py:344: undefined name 'time' ./layout_tests/test_types/fuzzy_image_diff.py:67: undefined name 'port' ./layout_tests/layout_package/test_expectations.py:182: undefined name 'JSONEncoder' ./style/processors/cpp_unittest.py:241: undefined name 'expected_message' Firt analysis: ./changelogs.py:60: undefined name 'contents': It should be self._contents ./layout_tests/port/base.py:334: undefined name 'stat' It should be os.stat ./layout_tests/test_types/fuzzy_image_diff.py:67: undefined name 'port' It should be self._port ./style/processors/cpp_unittest.py:241: undefined name 'expected_message' It should be expected_message_re Unknown: ./bugzilla.py:85: undefined name 'patch' ./layout_tests/port/http_server.py:220: undefined name 'google' ./layout_tests/port/base.py:344: undefined name 'time' ./layout_tests/test_types/fuzzy_image_diff.py:67: undefined name 'port' ./layout_tests/layout_package/test_expectations.py:182: undefined name 'JSONEncoder'
Attachments
Proposal of fixing some of the undefined names (4.84 KB, patch)
2010-03-19 20:54 PDT, Holger Freyther 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Holger Freyther
Comment 1 2010-03-19 20:54:20 PDT
Created attachment 51214 [details] Proposal of fixing some of the undefined names I'm relatively confident that I picked the right variables/modules for these.
Holger Freyther
Comment 2 2010-03-24 18:07:20 PDT
Landed in r56475.
Holger Freyther
Comment 3 2010-03-24 18:09:23 PDT
Reopening as more undefined names are left in the code.
Eric Seidel (no email)
Comment 4 2010-03-25 02:16:41 PDT
Comment on attachment 51214 [details] Proposal of fixing some of the undefined names LGTM. What's with the time import?
Eric Seidel (no email)
Comment 5 2010-03-25 02:17:20 PDT
Comment on attachment 51214 [details] Proposal of fixing some of the undefined names obsoleteing this landed patch.
Holger Freyther
Comment 6 2010-10-10 12:52:14 PDT
Closing for now... will open new bugs for new issues.
Note You need to log in before you can comment on or make changes to this bug.