Bug 36402
| Summary: | replace all occurrences of crbug.com and BUGXXXXX in Chromium test_expectations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dglazkov, fishd, ojan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Dirk Pranke
We need to do a pass over LayoutTests/platform/chromium/test_expectations.txt to update bug references to distinguish between webkit.org bug numberse and chromium.org bug numbers.
Ojan suggested something like WKXXXX and CRXXXX, or we could change BUGXXXXX to refer to webkit bugs and use CRXXXX for Chromium bugs.
Note that the actual text is meaningless to everything except for (as far as I know) some of the dashboards, like the Chromium LTTF dashboard and maybe the flakiness dashboards. Ojan - do you use the BUGXXXX syntax for anything in the flakiness dashboards?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ojan Vafai
Yes, but only in line 790 of trunk/tools/dashboards/flakiness_dashboard.html. The fix is just to change BUG to CR in that regexp. We'll also need a little bit of extra logic to also consider WKXXX as a bug instead of another kind of modifier.
Dirk Pranke
This was fixed a while ago (not sure when). We actually print out warnings now if you try to use the old BUGXXXX syntax.