Bug 36396 – disable chromium's downstream expectations and baselines temporarily for testing

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Dirk Pranke]

We need to temporarily not look in the downstream chromium.org repo for test expectations or baselines to make sure the upstream version is working correctly.

[Dirk Pranke]

Created attachment 51202 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 51202 [details]
Patch

beam me up, Scotty.

[Ojan Vafai]

Why temporarily? We should just do this permanently.

[Dirk Pranke]

(In reply to comment #3)
> Why temporarily? We should just do this permanently.

Well, we do actually want to keep the overrides file around. We can probably delete the downstream baseline paths permanently, but I'll at least leave the paths commented out until the directories have actually been removed.

[Ojan Vafai]

(In reply to comment #4)
> (In reply to comment #3)
> > Why temporarily? We should just do this permanently.
> 
> Well, we do actually want to keep the overrides file around. We can probably
> delete the downstream baseline paths permanently, but I'll at least leave the
> paths commented out until the directories have actually been removed.

The FIXME's imply that we won't remove the downstream directories.

I don't see the point in leaving in commented out code. If we want to add them back, the old lines are still in our revision history.

[Ojan Vafai]

Also, can't we just make the overrides file an empty text file, then we wouldn't need to comment out this code?

[Dirk Pranke]

Fair enough. I'll delete the lines for now.(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Why temporarily? We should just do this permanently.
> > 
> > Well, we do actually want to keep the overrides file around. We can probably
> > delete the downstream baseline paths permanently, but I'll at least leave the
> > paths commented out until the directories have actually been removed.
> 
> The FIXME's imply that we won't remove the downstream directories.
> 
> I don't see the point in leaving in commented out code. If we want to add them
> back, the old lines are still in our revision history.

Fair enough. I'll delete the lines for now.

[Dirk Pranke]

(In reply to comment #6)
> Also, can't we just make the overrides file an empty text file, then we
> wouldn't need to comment out this code?

No, since the file is in the chromium repo. Once we're content that the tests pass just looking at the webkit directories and the webkit expectations, we'll add the reference to the downstream file back in, and then when we do the next webkit roll, we'll empty out the file (and tell people what the process for updating it is).

[Dirk Pranke]

Note that, for the record, my confidence that we can tell people to simply put baselines upstream is pretty low. I bet people are going to want to be able to check in baselines downstream ...

[Dirk Pranke]

Committed r56287: <http://trac.webkit.org/changeset/56287>