| Summary: | disable chromium's downstream expectations and baselines temporarily for testing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
| Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dglazkov, ojan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Dirk Pranke
2010-03-19 16:17:24 PDT
Created attachment 51202 [details]
Patch
Comment on attachment 51202 [details]
Patch
beam me up, Scotty.
Why temporarily? We should just do this permanently. (In reply to comment #3) > Why temporarily? We should just do this permanently. Well, we do actually want to keep the overrides file around. We can probably delete the downstream baseline paths permanently, but I'll at least leave the paths commented out until the directories have actually been removed. (In reply to comment #4) > (In reply to comment #3) > > Why temporarily? We should just do this permanently. > > Well, we do actually want to keep the overrides file around. We can probably > delete the downstream baseline paths permanently, but I'll at least leave the > paths commented out until the directories have actually been removed. The FIXME's imply that we won't remove the downstream directories. I don't see the point in leaving in commented out code. If we want to add them back, the old lines are still in our revision history. Also, can't we just make the overrides file an empty text file, then we wouldn't need to comment out this code? Fair enough. I'll delete the lines for now.(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Why temporarily? We should just do this permanently. > > > > Well, we do actually want to keep the overrides file around. We can probably > > delete the downstream baseline paths permanently, but I'll at least leave the > > paths commented out until the directories have actually been removed. > > The FIXME's imply that we won't remove the downstream directories. > > I don't see the point in leaving in commented out code. If we want to add them > back, the old lines are still in our revision history. Fair enough. I'll delete the lines for now. (In reply to comment #6) > Also, can't we just make the overrides file an empty text file, then we > wouldn't need to comment out this code? No, since the file is in the chromium repo. Once we're content that the tests pass just looking at the webkit directories and the webkit expectations, we'll add the reference to the downstream file back in, and then when we do the next webkit roll, we'll empty out the file (and tell people what the process for updating it is). Note that, for the record, my confidence that we can tell people to simply put baselines upstream is pretty low. I bet people are going to want to be able to check in baselines downstream ... Committed r56287: <http://trac.webkit.org/changeset/56287> |