Bug 36392

Summary:

[Qt] Back-forward list dumping is incorrect

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fishd, tonikitoo

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2010-03-19 14:32:36 PDT

fast/loader/frame-src-change-added-to-history.html fails, 
because back-forward list dumping is incorrect in Qt-DRT.
( implemented by DumpRenderTree::dumpBackForwardList() )

http://build.webkit.org/results/Qt%20Linux%20Release/r56266%20%288803%29/fast/loader/frame-src-change-added-to-history-pretty-diff.html

Comment 1 Antonio Gomes 2010-03-19 14:34:10 PDT

I can have a look during the weekend.

Comment 2 Csaba Osztrogonác 2010-03-19 14:39:57 PDT

(In reply to comment #1)
> I can have a look during the weekend.
Thx. I skipped it to make bot happier: http://trac.webkit.org/changeset/56269

Comment 3 Darin Fisher (:fishd, Google) 2010-04-13 22:51:23 PDT

These tests seem to be failing for similar reasons:
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

Comment 4 Csaba Osztrogonác 2010-04-13 23:10:14 PDT

(In reply to comment #3)
> These tests seem to be failing for similar reasons:
> fast/loader/frame-src-change-not-added-to-history.html
> fast/loader/frame-location-change-not-added-to-history.html

Skipped by http://trac.webkit.org/changeset/57560 , thx for it.

Comment 5 Robert Hogan 2010-06-11 15:29:22 PDT

Created attachment 58513 [details]
Patch

Comment 6 WebKit Commit Bot 2010-06-12 00:36:16 PDT

Comment on attachment 58513 [details]
Patch

Clearing flags on attachment: 58513

Committed r61056: <http://trac.webkit.org/changeset/61056>

Comment 7 WebKit Commit Bot 2010-06-12 00:36:24 PDT

All reviewed patches have been landed.  Closing bug.