Bug 36365

Summary: [Qt] [Performance] GraphicsLayer: constructing the layers takes too long
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Noam Rosenthal <noam>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann, kim.1.gronholm
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
URL: http://script.aculo.us/stuff/sl150110/ui/
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
make GraphicsLayerQt manage the cache itself instead of using QGraphicsItem::cache
none
Fixed a problem in the first patch. Tested with all relevant LayoutTests
none
style/comments none

Description Noam Rosenthal 2010-03-19 07:08:56 PDT
There's a wait of ~350ms on some machines between clicking on the animation and until it starts.
That seems to be related to overhead created when constructing the GraphicsLayer scene.
Comment 1 Noam Rosenthal 2010-04-21 13:10:51 PDT
Created attachment 53981 [details]
make GraphicsLayerQt manage the cache itself instead of using QGraphicsItem::cache
Comment 2 Noam Rosenthal 2010-04-21 15:00:53 PDT
Created attachment 53995 [details]
Fixed a problem in the first patch. Tested with all relevant LayoutTests
Comment 3 Noam Rosenthal 2010-04-21 15:15:04 PDT
Created attachment 53996 [details]
style/comments
Comment 4 WebKit Commit Bot 2010-04-23 15:02:26 PDT
Comment on attachment 53996 [details]
style/comments

Clearing flags on attachment: 53996

Committed r58190: <http://trac.webkit.org/changeset/58190>
Comment 5 WebKit Commit Bot 2010-04-23 15:02:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Hausmann 2010-04-26 03:23:55 PDT
Revision r58190 cherry-picked into qtwebkit-2.0 with commit 991f4f6002271f4f98cf6a9057184bf3954a1d0c