Bug 36360

Summary:

Double clicking page's first editable inline element cannot select a word.

Product:

WebKit

Reporter:

Hajime Morrita <morrita>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, patrick, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
test case	none
patch v0	none
took the feedback	none
patch v7	none
Patch	none

Description Hajime Morrita 2010-03-19 05:18:51 PDT

Double clicking certain type of inline element  with contentEditable cannot select a clicked word.
See attached test-case for concrete example.

This one is similar to Bug 36359. But Its cause would be slightly different.
So I file this one separately.

reproduce:
- open the test html
- double-click "here" text

expected:
- selection range covers "here"
actual:
- the caret moves to the head of "here", with empty range.

Comment 1 Hajime Morrita 2010-03-19 05:24:03 PDT

Created attachment 51145 [details]
test case

Comment 2 Hajime Morrita 2010-03-19 06:37:05 PDT

Created attachment 51152 [details]
patch v0

Comment 3 Hajime Morrita 2010-03-22 18:26:06 PDT

Comment on attachment 51152 [details]
patch v0

This patch depends Bug 36359. So I'll cancel this one at now.

Comment 4 Hajime Morrita 2010-05-20 22:50:32 PDT

Created attachment 56672 [details]
took the feedback

Comment 5 Hajime Morrita 2010-05-20 22:52:11 PDT

Comment on attachment 56672 [details]
took the feedback

The patch was uploaded to wrong bug.  So I'll cancel review request.

Comment 6 Hajime Morrita 2010-05-27 01:35:55 PDT

Created attachment 57209 [details]
patch v7

Comment 7 Hajime Morrita 2010-05-27 01:36:48 PDT

Comment on attachment 57209 [details]
patch v7

wrong bug id. canceled.

Comment 8 WebKit Review Bot 2010-05-27 01:37:14 PDT

Attachment 57209 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/editing/TextIterator.cpp:1151:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Hajime Morrita 2010-08-05 23:27:44 PDT

Created attachment 63697 [details]
Patch

Comment 10 Hajime Morrita 2010-08-05 23:28:48 PDT

Comment on attachment 63697 [details]
Patch

wrong bug id again...

Comment 11 Hajime Morrita 2010-08-09 04:40:27 PDT

Committed r64974: <http://trac.webkit.org/changeset/64974>

Comment 12 Daniel Bates 2011-04-24 23:47:21 PDT

*** Bug 34534 has been marked as a duplicate of this bug. ***