| Summary: | [v8] Crash if the worker is terminated before its initial script is executed. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dmitry Titov <dimich> | ||||
| Component: | WebCore JavaScript | Assignee: | Dmitry Titov <dimich> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | atwilson, dglazkov | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Dmitry Titov
2010-03-18 16:43:49 PDT
Created attachment 51111 [details]
Patch.
I figured out a test for this, but it is a flakey test (because of timing involved). Thankfully, when it hits unfortunate timing, it is a false positive. When it fails, it's a failure.
Comment on attachment 51111 [details]
Patch.
Ok.
My only concern is with the (admittedly unavoidable) inherently flaky test. Do you happen to know what the false positive rate is?
> My only concern is with the (admittedly unavoidable) inherently flaky test. Do
> you happen to know what the false positive rate is?
It's fairly 'stable'. The v8 initialization takes ~50ms on a 2.6GHz machine, debug build. The termination request comes right about in the middle of that range at the moment, so I have 100% repro rate on my local Mac.
|