Summary: | QtLauncher doesn't start when using Qt/QWS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Bakken <agbakken> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric, hausmann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Anders Bakken
2010-03-18 12:39:35 PDT
Created attachment 51074 [details] This patch fixes the bug #36318 No objection from me, just curious: Why not pass -qws on the commandline? Or is that a recently changing trend in qws apps to not require it anymore but instead use this flag? Comment on attachment 51074 [details] This patch fixes the bug #36318 > LauncherApplication::LauncherApplication(int& argc, char** argv) > - : QApplication(argc, argv) > + : QApplication(argc, argv > +#ifdef Q_WS_QWS > + , QApplication::GuiServer > +#endif > + ) > , m_isRobotized(false) > { Is the #ifdef worth it? Why not always pass GuiServer? (In reply to comment #2) > No objection from me, just curious: Why not pass -qws on the commandline? Or is > that a recently changing trend in qws apps to not require it anymore but > instead use this flag? Mostly because I didn't easily understand how to add arguments to the scripts that run the launcher (webkit-tests etc). It seemed like it requires hacking perl code. (In reply to comment #3) > (From update of attachment 51074 [details]) > > > LauncherApplication::LauncherApplication(int& argc, char** argv) > > - : QApplication(argc, argv) > > + : QApplication(argc, argv > > +#ifdef Q_WS_QWS > > + , QApplication::GuiServer > > +#endif > > + ) > > , m_isRobotized(false) > > { > > Is the #ifdef worth it? Why not always pass GuiServer? No reason. I am fine with changing that. It's a noop on desktop anyway. Created attachment 51086 [details]
Updated patch for 36318
Comment on attachment 51086 [details]
Updated patch for 36318
Thanks Anders :)
Comment on attachment 51086 [details] Updated patch for 36318 Rejecting patch 51086 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Committed r56222: <http://trac.webkit.org/changeset/56222> @simon: There was a bug in the ChangeLog, which is why the queue rejected it. You didn't correct it when you landed either. :( double >> in the date line. (In reply to comment #10) > @simon: > > There was a bug in the ChangeLog, which is why the queue rejected it. You > didn't correct it when you landed either. :( > > double >> in the date line. Oops! Indeed, the name appeared twice with too many angle brackets. Fixed up in r56364. /me bows low to the bot and his/her master |