Bug 36308

Summary: [EFL] Add EFL-specific code to Icon.h, IntRect.h, FloatRect.h and IntPoint.h.
Product: WebKit Reporter: Leandro Pereira <leandro>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
EFL-specific changes to Icon.h, IntRect.h, FloatRect.h and IntPoint.h none

Leandro Pereira
Reported 2010-03-18 11:06:42 PDT
Attached patch adds EFL-specific code to WebCore/platform/graphics/Icon.h, WebCore/platform/graphics/IntRect.h, WebCore/platform/graphics/FloatRect.h and WebCore/platform/graphics/IntPoint.h.
Attachments
EFL-specific changes to Icon.h, IntRect.h, FloatRect.h and IntPoint.h (3.09 KB, patch)
2010-03-18 11:07 PDT, Leandro Pereira 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leandro Pereira
Comment 1 2010-03-18 11:07:29 PDT
Created attachment 51056 [details] EFL-specific changes to Icon.h, IntRect.h, FloatRect.h and IntPoint.h
WebKit Review Bot
Comment 2 2010-03-18 11:08:31 PDT
Attachment 51056 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/IntPoint.h:60: Evas_Point is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/IntPoint.h:136: Evas_Point is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/IntRect.h:160: Eina_Rectangle is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/FloatRect.h:154: Eina_Rectangle is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Leandro Pereira
Comment 3 2010-03-18 11:16:09 PDT
(In reply to comment #2) > Attachment 51056 [details] did not pass style-queue: > WebCore/platform/graphics/IntPoint.h:60: Evas_Point is incorrectly named. > Don't use underscores in your identifier names. [readability/naming] [4] > (snip) The underscores are part of EFL's types, they can't be changed.
Eric Seidel (no email)
Comment 4 2010-03-24 23:53:23 PDT
Comment on attachment 51056 [details] EFL-specific changes to Icon.h, IntRect.h, FloatRect.h and IntPoint.h Please include the implementation files.
Leandro Pereira
Comment 5 2010-03-25 07:17:12 PDT
(In reply to comment #4) > (From update of attachment 51056 [details]) > Please include the implementation files. They're already on SVN: http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/efl
Leandro Pereira
Comment 6 2010-03-31 07:41:13 PDT
Comment on attachment 51056 [details] EFL-specific changes to Icon.h, IntRect.h, FloatRect.h and IntPoint.h r? it again because the implementation files are already on the repo.
WebKit Commit Bot
Comment 7 2010-04-05 20:50:53 PDT
Comment on attachment 51056 [details] EFL-specific changes to Icon.h, IntRect.h, FloatRect.h and IntPoint.h Clearing flags on attachment: 51056 Committed r57118: <http://trac.webkit.org/changeset/57118>
WebKit Commit Bot
Comment 8 2010-04-05 20:50:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.