Bug 36304 – Web Inspector: CSS shorthand properties expand unnecessarily

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[paradox]

If you type certain properties into the web inspectors CSS edit area, they expand in a manner that can prove quite annoying.

To reproduce, open inspector, and add a new property. Type border-radius: 5px; Hit return
The property will expand to 4 different properties: border-top-left-radius: 5px 5px; etc

Possible solution:
Cause the border-radius to remain as one complex syntax, with an expanding dropdown, much like with other properties, of the sub-properties.

[Timothy Hatcher]

This is a regression. We use to handle this correctly.

[Pavel Feldman]

(In reply to comment #1)
> This is a regression. We use to handle this correctly.

That's what comment was saying:

// Some shorthands (like border) return a null value, so compute a shorthand value. 
// FIXME: remove this when http://bugs.webkit.org/show_bug.cgi?id=15823 is fixed.

Turns out it was not only 15823.

[Pavel Feldman]

Ok, I can now see that the bug is still open. Turns out only test has landed for it. Bringing the hack back...

[Pavel Feldman]

I don't think this is regression - style does not return shorthand for border-radius specifically. It works with the rest of the shorthands.

[Alexander Pavlov (apavlov)]

Created attachment 77319 [details]
[PATCH] Suggested fix

[Eric Seidel (no email)]

Comment on attachment 77319 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=77319&action=review

This patch needs more explanation in the ChangeLog of what's going on and why its' right.

> WebCore/css/CSSParser.cpp:4601
> +    m_implicitShorthand = true;

Why is this needed separately from a shorthand scope?

[Maciej Stachowiak]

Comment on attachment 77319 [details]
[PATCH] Suggested fix

r=me

[Maciej Stachowiak]

Comment on attachment 77319 [details]
[PATCH] Suggested fix

r=me

[Alexander Pavlov (apavlov)]

(In reply to comment #6)
> (From update of attachment 77319 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77319&action=review
> 
> This patch needs more explanation in the ChangeLog of what's going on and why its' right.

Fixed.

> > WebCore/css/CSSParser.cpp:4601
> > +    m_implicitShorthand = true;
> 
> Why is this needed separately from a shorthand scope?

Filed bug 51586 for that.

[Alexander Pavlov (apavlov)]

Landed with the comments addressed: http://trac.webkit.org/changeset/74630