Summary: | [Qt] LayoutTests/fast/canvas/arc360.html failed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | qi <qi.2.zhang> | ||||||
Component: | New Bugs | Assignee: | qi <qi.2.zhang> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, cshu, hausmann | ||||||
Priority: | P3 | Keywords: | Qt | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
qi
2010-03-18 08:41:02 PDT
Created attachment 51047 [details]
fix canvas arc function to enable LayoutTests/fast/canvas/arc360.html
At HTLM5 spec (4.8.10.1.8 Complex shapes):
context . arc (x, y, radius, startAngle, endAngle, anticlockwise)
Adds points to the subpath such that the arc described by the circumference of the circle described by
the arguments, starting at the given start angle and ending at the given end angle, going in the given
direction, is added to the path, connected to the previous point by a straight line.
Throws an INDEX_SIZE_ERRp64 exception if the given radius is negative.
arc function should draw a line to previous point, not only the arc.
Comment on attachment 51047 [details]
fix canvas arc function to enable LayoutTests/fast/canvas/arc360.html
Please elaborate a little bit more in the ChangeLog when landing.
Thanks, I will do that. Bugs relating to the Qt port of WebKit should have the Qt keyword. See http://trac.webkit.org/wiki/QtWebKitBugs Created attachment 51287 [details]
More description on patch
Based on comments, add more description on ChangeLog.
Comment on attachment 51287 [details] More description on patch Clearing flags on attachment: 51287 Committed r56382: <http://trac.webkit.org/changeset/56382> All reviewed patches have been landed. Closing bug. |