Bug 36210

Summary:

plugins/resize-from-plugin.html fails on Qt

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

Plug-ins

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ap, eric, jturcotte, kling, ossy

Priority:

Keywords:

LayoutTestFailure, Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Other

OS:

All

Attachments:

Description	Flags
proposed patch	none

Description Maciej Stachowiak 2010-03-17 00:56:51 PDT

Some tests failing or crashing on Gtk/Qt with r56079

Comment 1 Alexey Proskuryakov 2010-03-17 10:16:16 PDT

The new test added in r56079 was plugins/resize-from-plugin.html. It's failing due to a pre-existing issue, NPP_SetWindow seemingly isn't ever called:

-x: 18, y: 52, width: 200, height: 200, clipRect: (18, 52, 200, 142)
+x: 6619246, y: 7536756, width: 6357091, height: 6619248, clipRect: (0, 0, 0, 0)
 Height and width should equal 200, and the plug-in size should not change on scroll.

Another test that's skipped on Gtk with a reference to this bug is plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html. It was added in r34988, and r56079 couldn't affect it in any way. It does seem to crash randomly, and needs a separate bug.

Comment 2 Alexey Proskuryakov 2010-03-17 14:31:12 PDT

Filed bug 36228 for the old crashing test.

Comment 3 Alexey Proskuryakov 2010-03-18 10:47:27 PDT

It also fails on Windows. I have a patch that should get us closer.

Comment 4 Alexey Proskuryakov 2010-03-18 10:55:11 PDT

Created attachment 51051 [details]
proposed patch

Comment 5 Adam Roben (:aroben) 2010-03-18 10:58:07 PDT

Comment on attachment 51051 [details]
proposed patch

r=me, though you could ask Anders Carlsson or Jon Honeycutt to look at the different result on Windows.

Comment 6 Alexey Proskuryakov 2010-03-18 11:08:06 PDT

Anders came up with an explanation, which I've put into ChangeLog.

Committed <http://trac.webkit.org/changeset/56172>, and closing. We can reopen if bots are still unhappy.

Comment 7 Alexey Proskuryakov 2010-03-18 11:35:02 PDT

I'll land new results for Gtk - it gets a different clip rect, which may or may not be correct.

Will also take results for Qt from buildbot, but these a definite failure.

Comment 8 Eric Seidel (no email) 2010-03-24 14:33:39 PDT

Attachment 51051 [details] was posted by a committer and has review+, assigning to Alexey Proskuryakov for commit.

Comment 9 Alexey Proskuryakov 2010-03-24 14:44:33 PDT

Comment on attachment 51051 [details]
proposed patch

Clearing review on a landed patch.

Comment 10 Alexey Proskuryakov 2010-03-24 14:45:02 PDT

This bug now represents a Qt problem with this test.

Comment 11 Andreas Kling 2010-06-30 03:04:06 PDT


*** This bug has been marked as a duplicate of bug 40879 ***