Bug 36180

Summary: [6~ [C36147
Product: WebKit Reporter: John Abd-El-Malek <jam>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: darin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

John Abd-El-Malek
Reported 2010-03-16 12:13:27 PDT
[6~[C36147
Attachments
Patch (8.92 KB, patch)
2010-03-16 12:17 PDT, John Abd-El-Malek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Abd-El-Malek
Comment 1 2010-03-16 12:17:34 PDT
Created attachment 50820 [details] Patch
Darin Adler
Comment 2 2010-03-16 12:18:11 PDT
The title of this bug needs to be fixed, here and in the patch.
WebKit Review Bot
Comment 3 2010-03-16 12:18:20 PDT
Attachment 50820 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:114: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:114: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
John Abd-El-Malek
Comment 4 2010-03-16 12:19:35 PDT
sorry i typed in the wrong bug id by mistake. looks like webkit-patch has issues with backspace, eric has already filed a bug.
David Levin
Comment 5 2010-03-16 13:46:03 PDT
Comment on attachment 50820 [details] Patch Clearing r? to move out of the review queue.
Note You need to log in before you can comment on or make changes to this bug.