Bug 36175 – [Qt] Make QtLaucher able to select the ViewportUpdateMode

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Diego Gonzalez]

Provide to QtLauncher a way to change the ViewPortUpdateMode
when it's in graphics based mode.

[Diego Gonzalez]

Created attachment 50811 [details]
Proposed patch

[Kenneth Rohde Christiansen]

Comment on attachment 50811 [details]
Proposed patch


> +void LauncherWindow::selectViewportUpdateMode(int mode)

select is not a really good name for this. Consider using "change" or "set"


> +{
> +    if (!isGraphicsBased())
> +        return;

I guess you should update the gViewportUpdateMode anyway, so you are bailing out a bit too early

> +
> +    gViewportUpdateMode = QGraphicsView::ViewportUpdateMode(mode);
> +    WebViewGraphicsBased* view = static_cast<WebViewGraphicsBased*>(m_view);
> +    view->setViewportUpdateMode(gViewportUpdateMode);
> +}

[Diego Gonzalez]

Created attachment 50827 [details]
(committed in r56117) Proposed patch

Changed according Kenneth's suggestions

[Benjamin Poulain]

Setting the status of the task so it does not appear unassigned.


I might misunderstand the purpose of the patch but for me this should not go in QtLauncher.

If the objective is to compare performance, you should create a reduction in the webkit benchmarks. Definitely not update the launcher.
If the objective is to find bugs, you should add autotests in graphicsview.

Why do you need that in the launcher?

[Jesus Sanchez-Palencia]

(In reply to comment #4)
> Why do you need that in the launcher?

QtLauncher is becoming a more complete test tool of QtWebKit. And we are focusing on mobile tests (Symbian and Maemo).

We are following https://bugs.webkit.org/show_bug.cgi?id=35303 requirements, some ideas from Simon and others, to have all command line options as menu options on the Launcher. With this it will become easier to test QtWebKit on Symbian devices.

[Benjamin Poulain]

(In reply to comment #5)
> We are following https://bugs.webkit.org/show_bug.cgi?id=35303 requirements,

This bug does not say why such options would be required, neither why it is specific to Symbian.

[Jesus Sanchez-Palencia]

(In reply to comment #6)
> This bug does not say why such options would be required, neither why it is
> specific to Symbian.

Yes, that is true. My guess is that No'am is mainly working with Symbian debugging and that is why he opened the bug. But I don't think that those wanted features are Symbian specific, that is why we are leaving them available for any platform/OS.

[Antonio Gomes]

Comment on attachment 50827 [details]
(committed in r56117) Proposed patch

the ChangeLog was wrong =/

Fixed, and landed manually in r56117