Bug 36158

Summary: [Qt] [Performance] GraphicsLayerQt updates the scene too often
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: PlatformAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, eric, koivisto
Priority: P2 Keywords: Performance, Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Call the flush functions asynchronously none

Noam Rosenthal
Reported 2010-03-16 00:41:14 PDT
This is due to wrong handling of the synchronization code path
Attachments
Call the flush functions asynchronously (11.36 KB, patch)
2010-03-16 08:13 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2010-03-16 08:13:57 PDT
Created attachment 50791 [details] Call the flush functions asynchronously
Antti Koivisto
Comment 2 2010-03-16 08:21:31 PDT
Comment on attachment 50791 [details] Call the flush functions asynchronously Looks great, r=me
WebKit Commit Bot
Comment 3 2010-03-17 22:09:14 PDT
Comment on attachment 50791 [details] Call the flush functions asynchronously Rejecting patch 50791 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12495 test cases. fast/loader/api-test-new-window-data-load-base-url.html -> failed Exiting early after 1 failures. 7692 tests run. 128.41s total testing time 7691 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/972003
Noam Rosenthal
Comment 4 2010-03-18 00:57:18 PDT
This is strange. The failed test has absolutely nothing to do with my change. How do I go about it?
Noam Rosenthal
Comment 5 2010-03-18 01:01:29 PDT
Comment on attachment 50791 [details] Call the flush functions asynchronously Failed tests are coincidental with the patch. Confirmed that they fail even before applying it.
Antonio Gomes
Comment 6 2010-03-18 07:23:25 PDT
Comment on attachment 50791 [details] Call the flush functions asynchronously lets try again
WebKit Commit Bot
Comment 7 2010-03-18 07:42:27 PDT
Comment on attachment 50791 [details] Call the flush functions asynchronously Clearing flags on attachment: 50791 Committed r56158: <http://trac.webkit.org/changeset/56158>
WebKit Commit Bot
Comment 8 2010-03-18 07:42:32 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 9 2010-03-22 12:30:55 PDT
(In reply to comment #3) > (From update of attachment 50791 [details]) > Rejecting patch 50791 from commit-queue. > > Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', > '--exit-after-n-failures=1', '--quiet']" exit_code: 1 > Running build-dumprendertree > Compiling Java tests > make: Nothing to be done for `default'. > Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests > Testing 12495 test cases. > fast/loader/api-test-new-window-data-load-base-url.html -> failed This was bug 35594.
Note You need to log in before you can comment on or make changes to this bug.