| Summary: | [Qt] [Performance] GraphicsLayerQt updates the scene too often | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||
| Component: | Platform | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, commit-queue, eric, koivisto | ||||
| Priority: | P2 | Keywords: | Performance, Qt | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Noam Rosenthal
2010-03-16 00:41:14 PDT
Created attachment 50791 [details]
Call the flush functions asynchronously
Comment on attachment 50791 [details]
Call the flush functions asynchronously
Looks great, r=me
Comment on attachment 50791 [details] Call the flush functions asynchronously Rejecting patch 50791 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12495 test cases. fast/loader/api-test-new-window-data-load-base-url.html -> failed Exiting early after 1 failures. 7692 tests run. 128.41s total testing time 7691 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/972003 This is strange. The failed test has absolutely nothing to do with my change. How do I go about it? Comment on attachment 50791 [details]
Call the flush functions asynchronously
Failed tests are coincidental with the patch. Confirmed that they fail even before applying it.
Comment on attachment 50791 [details]
Call the flush functions asynchronously
lets try again
Comment on attachment 50791 [details] Call the flush functions asynchronously Clearing flags on attachment: 50791 Committed r56158: <http://trac.webkit.org/changeset/56158> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > (From update of attachment 50791 [details]) > Rejecting patch 50791 from commit-queue. > > Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', > '--exit-after-n-failures=1', '--quiet']" exit_code: 1 > Running build-dumprendertree > Compiling Java tests > make: Nothing to be done for `default'. > Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests > Testing 12495 test cases. > fast/loader/api-test-new-window-data-load-base-url.html -> failed This was bug 35594. |