Summary: | [chromium] Add support for history.pushState and history.replaceState | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Fisher (:fishd, Google) <fishd> | ||||
Component: | Page Loading | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dglazkov, levin, vitalyr | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Darin Fisher (:fishd, Google)
2010-03-15 21:04:39 PDT
Created attachment 50758 [details]
v1 patch
With this patch, all stateobject layout tests pass except for: fast/loader/stateobjects/pushstate-object-types.html = TEXT fast/loader/stateobjects/state-api-on-detached-frame-crash.html = TEXT The first fails due to differences in the way we serialize Date and RegExp objects. The second fails due to an exception thrown--not a crash, which the test was written to detect--while trying to access window.history.replaceState on a detached window (from an iframe that has been removed). Comment on attachment 50758 [details]
v1 patch
Ok. I'm sad about backForwardNavigationScheme, but it looks like that's already there...
590 bool isHashChange =
591 !m_webFrame->frame()->loader()->history()->currentItem()->stateObject();
No need to line break in WebKit-land.
Thanks Adam. Yes, backForwardNavigationScheme is the suck. This change makes it suck a bit less since it will be seen by much less code; however, I really need to kill it somehow. It should be pretty easy to do :) > 590 bool isHashChange =
> 591
> !m_webFrame->frame()->loader()->history()->currentItem()->stateObject();
>
> No need to line break in WebKit-land.
Right, but line breaking like this is optional, no? There are a number of similar line breaks in the same function and in this file. I prefer to leave the line breaks for readability.
Landed as http://trac.webkit.org/changeset/56070 > Right, but line breaking like this is optional, no?
Yes, it's optional.
|