Bug 36149

Summary:

webkit-patch upload includes "delete" characters in bug description

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cjerdonek, dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Eric Seidel (no email)

Reported 2010-03-15 19:06:14 PDT

webkit-patch upload includes "delete" characters in bug description I suspect it's a question of using readline instead of rawinput in our user.py module. https://bugs.webkit.org/show_bug.cgi?id=36147#c0

Attachments
Patch (1.12 KB, patch) 2010-03-23 13:32 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2010-03-23 13:32:46 PDT

Created attachment 51448 [details] Patch From my understanding of <http://docs.python.org/library/functions.html#raw_input> and <http://docs.python.org/library/readline.html#module-readline> it should be sufficient to import the GNU readline module. I am not sure how to write a unit test for this patch since it seems we need to be able simulate an interactive terminal session. I am open to suggestions.

Adam Barth

Comment 2 2010-03-23 13:45:48 PDT

Comment on attachment 51448 [details] Patch Awesome! Yeah, user.py is hard to unit test because it exists to abstract out the bits that are hard to unit test. :)

Daniel Bates

Comment 3 2010-03-23 13:51:54 PDT

Comment on attachment 51448 [details] Patch Clearing flags on attachment: 51448 Committed r56413: <http://trac.webkit.org/changeset/56413>

Daniel Bates

Comment 4 2010-03-23 13:52:03 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.