|Summary:||webkit-patch upload includes "delete" characters in bug description|
|Product:||WebKit||Reporter:||Eric Seidel (no email) <eric>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||abarth, cjerdonek, dbates|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Eric Seidel (no email) 2010-03-15 19:06:14 PDT
webkit-patch upload includes "delete" characters in bug description I suspect it's a question of using readline instead of rawinput in our user.py module. https://bugs.webkit.org/show_bug.cgi?id=36147#c0
Comment 1 Daniel Bates 2010-03-23 13:32:46 PDT
Created attachment 51448 [details] Patch From my understanding of <http://docs.python.org/library/functions.html#raw_input> and <http://docs.python.org/library/readline.html#module-readline> it should be sufficient to import the GNU readline module. I am not sure how to write a unit test for this patch since it seems we need to be able simulate an interactive terminal session. I am open to suggestions.
Comment 2 Adam Barth 2010-03-23 13:45:48 PDT
Comment on attachment 51448 [details] Patch Awesome! Yeah, user.py is hard to unit test because it exists to abstract out the bits that are hard to unit test. :)
Comment 3 Daniel Bates 2010-03-23 13:51:54 PDT
Comment on attachment 51448 [details] Patch Clearing flags on attachment: 51448 Committed r56413: <http://trac.webkit.org/changeset/56413>
Comment 4 Daniel Bates 2010-03-23 13:52:03 PDT
All reviewed patches have been landed. Closing bug.