Summary: | NULL pointer access in webkit_web_window_features_equal() | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philip Chimento <philip.chimento> | ||||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Major | CC: | commit-queue, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | Linux | ||||||||||||
Attachments: |
|
Attachment 50747 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Total errors found: 0 in 0 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 50747 [details] Patch against svn trunk All changes require ChangeLog entries and test cases. See http://webkit.org/coding/contributing.html Created attachment 51092 [details]
Updated patch that conforms to guidelines
Okayyyy, here's another patch.
Attachment 51092 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/webkit/webkitwebview.cpp:3018: Missing space before ( in if( [whitespace/parens] [5]
WebKit/gtk/webkit/webkitwebview.cpp:3018: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testwebview.c"
WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:427: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 51096 [details]
Another patch
Whatever
Attachment 51096 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testwebview.c"
WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:433: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:434: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:435: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:436: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:437: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:438: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:439: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:440: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:441: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Total errors found: 9 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 51098 [details]
Another patch
Now I'm correcting style transgressions that weren't even mine!
Comment on attachment 51098 [details]
Another patch
r=me
Comment on attachment 51098 [details] Another patch Clearing flags on attachment: 51098 Committed r56217: <http://trac.webkit.org/changeset/56217> All reviewed patches have been landed. Closing bug. |
Created attachment 50747 [details] Patch against svn trunk If you try to set the 'window-features' GObject property to NULL, then webkit-gtk crashes. You may ask, why would I want to set that property to NULL? Well, if I use the Glade application to construct a user interface containing WebKitWebViews, then it happens. I have attached a patch.