Bug 36131

Summary:

[chromium] update includes for rect.h, point.h, and size.h

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

WebKit API

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beng, dglazkov, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
v1 patch	fishd: commit-queue-
v2 patch	levin: review+, fishd: commit-queue-

Darin Fisher (:fishd, Google)

Reported 2010-03-15 13:13:16 PDT

[chromium] update includes for rect.h, point.h, and size.h These moved on the chromium side from base/gfx/ to gfx/.

Attachments
v1 patch (1.69 KB, patch) 2010-03-15 13:14 PDT, Darin Fisher (:fishd, Google)	fishd: commit-queue-	Details Formatted Diff Diff
v2 patch (2.25 KB, patch) 2010-03-15 14:08 PDT, Darin Fisher (:fishd, Google)	levin: review+ fishd: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2010-03-15 13:14:06 PDT

Created attachment 50730 [details] v1 patch

WebKit Review Bot

Comment 2 2010-03-15 13:20:10 PDT

Attachment 50730 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/850007

Darin Fisher (:fishd, Google)

Comment 3 2010-03-15 14:08:10 PDT

Created attachment 50735 [details] v2 patch And update the chromium repository pulled by our standalone webkit build.

WebKit Review Bot

Comment 4 2010-03-15 14:11:19 PDT

Attachment 50735 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/838013

David Levin

Comment 5 2010-03-15 15:48:15 PDT

Comment on attachment 50735 [details] v2 patch r=me if the build issue for chromium is fixed :)

Darin Fisher (:fishd, Google)

Comment 6 2010-03-15 15:57:20 PDT

Thanks David. Yeah, that one is surprising.

Darin Fisher (:fishd, Google)

Comment 7 2010-03-15 16:29:00 PDT

Landed as http://trac.webkit.org/changeset/56024 Eric says they'll just have to kick the EWS bot manually to pick up the DEPS change.

Eric Seidel (no email)

Comment 8 2010-03-15 19:00:26 PDT

This appears to have broken two of the chromium builders at http://build.webkit.org/console

Note You need to log in before you can comment on or make changes to this bug.