Bug 36131

Summary: [chromium] update includes for rect.h, point.h, and size.h
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: WebKit APIAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal CC: beng, dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch
fishd: commit-queue-
v2 patch levin: review+, fishd: commit-queue-

Description Darin Fisher (:fishd, Google) 2010-03-15 13:13:16 PDT 
[chromium] update includes for rect.h, point.h, and size.h

These moved on the chromium side from base/gfx/ to gfx/.
Comment 1 Darin Fisher (:fishd, Google) 2010-03-15 13:14:06 PDT 
Created attachment 50730 [details]
v1 patch
Comment 2 WebKit Review Bot 2010-03-15 13:20:10 PDT 
Attachment 50730 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/850007
Comment 3 Darin Fisher (:fishd, Google) 2010-03-15 14:08:10 PDT 
Created attachment 50735 [details]
v2 patch

And update the chromium repository pulled by our standalone webkit build.
Comment 4 WebKit Review Bot 2010-03-15 14:11:19 PDT 
Attachment 50735 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/838013
Comment 5 David Levin 2010-03-15 15:48:15 PDT 
Comment on attachment 50735 [details]
v2 patch

r=me if the build issue for chromium is fixed :)
Comment 6 Darin Fisher (:fishd, Google) 2010-03-15 15:57:20 PDT 
Thanks David.  Yeah, that one is surprising.
Comment 7 Darin Fisher (:fishd, Google) 2010-03-15 16:29:00 PDT 
Landed as http://trac.webkit.org/changeset/56024

Eric says they'll just have to kick the EWS bot manually to pick up the DEPS change.
Comment 8 Eric Seidel (no email) 2010-03-15 19:00:26 PDT 
This appears to have broken two of the chromium builders at http://build.webkit.org/console