Bug 36108

Summary: option-pageup/down should move cursor on chromium mac
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2010-03-15 01:37:02 PDT
option-pageup/down should move cursor on chromium mac
Attachments
Patch (2.59 KB, patch)
2010-03-15 01:38 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (3.27 KB, patch)
2010-03-15 02:34 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-03-15 01:38:52 PDT
Created attachment 50691 [details] Patch
Tony Chang
Comment 2 2010-03-15 02:34:11 PDT
Created attachment 50697 [details] Patch
Tony Chang
Comment 3 2010-03-15 02:34:57 PDT
Comment on attachment 50697 [details] Patch Update to disable pageup/pagedown on mac from moving the cursor. This shouldn't be handled in the editing code and is handled by the scroll code that happens first.
Tony Chang
Comment 4 2010-03-15 02:40:35 PDT
Ojan, want to do a non-reviewer review?
Darin Adler
Comment 5 2010-03-15 08:18:55 PDT
Comment on attachment 50697 [details] Patch > +#if !OS(DARWIN) > { VKEY_PRIOR, 0, "MovePageUp" }, > { VKEY_NEXT, 0, "MovePageDown" }, > +#endif Long term this is not the right way to conditional user-interface differences between platforms. But I suppose Chromium does this consistently for Mac-specific user interface choices, and cleaning that up can wait for the changes Maciej proposed to clean up the platform conditionals to be deployed. And I care more about the way this is done in shared code than in Chromium-specific code. r=me
WebKit Commit Bot
Comment 6 2010-03-15 08:54:45 PDT
Comment on attachment 50697 [details] Patch Clearing flags on attachment: 50697 Committed r55998: <http://trac.webkit.org/changeset/55998>
WebKit Commit Bot
Comment 7 2010-03-15 08:54:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.