Bug 36108

Summary:

option-pageup/down should move cursor on chromium mac

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Description Tony Chang 2010-03-15 01:37:02 PDT

option-pageup/down should move cursor on chromium mac

Comment 1 Tony Chang 2010-03-15 01:38:52 PDT

Created attachment 50691 [details]
Patch

Comment 2 Tony Chang 2010-03-15 02:34:11 PDT

Created attachment 50697 [details]
Patch

Comment 3 Tony Chang 2010-03-15 02:34:57 PDT

Comment on attachment 50697 [details]
Patch

Update to disable pageup/pagedown on mac from moving the cursor.  This shouldn't be handled in the editing code and is handled by the scroll code that happens first.

Comment 4 Tony Chang 2010-03-15 02:40:35 PDT

Ojan, want to do a non-reviewer review?

Comment 5 Darin Adler 2010-03-15 08:18:55 PDT

Comment on attachment 50697 [details]
Patch

> +#if !OS(DARWIN)
>      { VKEY_PRIOR,  0,                  "MovePageUp"                           },
>      { VKEY_NEXT,   0,                  "MovePageDown"                         },
> +#endif

Long term this is not the right way to conditional user-interface differences between platforms. But I suppose Chromium does this consistently for Mac-specific user interface choices, and cleaning that up can wait for the changes Maciej proposed to clean up the platform conditionals to be deployed. And I care more about the way this is done in shared code than in Chromium-specific code.

r=me

Comment 6 WebKit Commit Bot 2010-03-15 08:54:45 PDT

Comment on attachment 50697 [details]
Patch

Clearing flags on attachment: 50697

Committed r55998: <http://trac.webkit.org/changeset/55998>

Comment 7 WebKit Commit Bot 2010-03-15 08:54:50 PDT

All reviewed patches have been landed.  Closing bug.