Bug 36101 – Add iExploder 1.7.2 to WebKitTools

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

* SUMMARY
iExploder 1.5 is now available.  It could be merged into WebKitTools if anyone finds that useful.

[Holger Freyther]

Would we want to replace our copy of the tool with it or would we add it next to the current iexploder version?

[Lucas Forschler]

Created attachment 76247 [details]
Add iExploder 1.7.2.  move iExploder 1.3.2 into it's unique directory.  (keeping it around for potential repro scenarios)

This adds iExploder 1.7.2 to the tree
This moves iExploder 1.3.2 into an iExploder-1.3.2 subdirectory.
We skipped iExploder 1.5, as the bug was previously targeted, since 1.7.2 is avialable.

[Adam Barth]

Comment on attachment 76247 [details]
Add iExploder 1.7.2.  move iExploder 1.3.2 into it's unique directory.  (keeping it around for potential repro scenarios)

View in context: https://bugs.webkit.org/attachment.cgi?id=76247&action=review

> WebKitTools/ChangeLog:8
> +	Moved 1.3.2 into its own directory.
> +	Added 1.7.2 into its own directory.
> +	Verified nothing in /Opensource references iexploder.rb or webserver.rb which might be broken due to move

We can't land patches with tabs.

[David Kilzer (:ddkilzer)]

Note that WebKitTools/Scripts/update-iexploder-cssproperties will have to be updated to use the new paths once this lands.  (I suspect we want to point it at the 1.3.2 directory first, then make it work with 1.7.2.)

[Lucas Forschler]

Created attachment 76257 [details]
Update iExploder from 1.3.2 to 1.7.2

[Lucas Forschler]

Created attachment 76260 [details]
Update iexploder 1.3.2 to 1.7.2 and fixup scripts

[Lucas Forschler]

Created attachment 76262 [details]
update iexploder 1.3.2 to 1.7.2 and fixup scripts

[David Kilzer (:ddkilzer)]

Comment on attachment 76262 [details]
update iexploder 1.3.2 to 1.7.2 and fixup scripts

r=me

[WebKit Commit Bot]

Comment on attachment 76262 [details]
update iexploder 1.3.2 to 1.7.2 and fixup scripts

Rejecting attachment 76262 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--non-interactive', 76262]" exit_code: 1
Last 500 characters of output:
ls/Scripts/webkitpy/common/system/executive.py", line 347, in run_command
    output = process.communicate(string_to_communicate)[0]
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/subprocess.py", line 671, in communicate
    return self._communicate(input)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/subprocess.py", line 1177, in _communicate
    bytes_written = os.write(self.stdin.fileno(), chunk)
OSError: [Errno 32] Broken pipe

Full output: http://queues.webkit.org/results/6893044

[Eric Seidel (no email)]

Comment on attachment 76262 [details]
update iexploder 1.3.2 to 1.7.2 and fixup scripts

I'm not sure why it failed.  But it looks like this patch makes bots mad anyway, so it probably needs another round.

[David Kilzer (:ddkilzer)]

(In reply to comment #10)
> (From update of attachment 76262 [details])
> I'm not sure why it failed.  But it looks like this patch makes bots mad anyway, so it probably needs another round.

I suspect it's due to the renamed directory in the patch.  This currently isn't handled by svn-create-patch (see Bug 14590).

I would just land this patch manually, Lucas.  Grab Stephanie or someone else with commit access.

[Adam Barth]

This patch appears to have already landed.