Summary: | [Qt] LayoutTests/fast/canvas/canvas-text-baseline.html skipped on Qt | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chang Shu <cshu> | ||||
Component: | Tools / Tests | Assignee: | Chang Shu <cshu> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric | ||||
Priority: | P3 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Chang Shu
2010-03-12 08:29:28 PST
Created attachment 50601 [details]
fix patch
Comment on attachment 50601 [details]
fix patch
OK. Your ChangeLog should ideally explain why the baseline is different from the common one.
(In reply to comment #2) > (From update of attachment 50601 [details]) > OK. Your ChangeLog should ideally explain why the baseline is different from > the common one. Thanks, Eric. The root cause should be Qt upgrade, which made some font size difference. Is it ok I put this info in the similar problems later, if any? Comment on attachment 50601 [details] fix patch Rejecting patch 50601 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12491 test cases. fast/loader/api-test-new-window-data-load-base-url.html -> failed Exiting early after 1 failures. 7691 tests run. 128.89s total testing time 7690 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/852028 (In reply to comment #4) > (From update of attachment 50601 [details]) > Rejecting patch 50601 from commit-queue. > > Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', > '--exit-after-n-failures=1', '--quiet']" exit_code: 1 > Running build-dumprendertree > Compiling Java tests > make: Nothing to be done for `default'. > Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests > Testing 12491 test cases. > fast/loader/api-test-new-window-data-load-base-url.html -> failed > > Exiting early after 1 failures. 7691 tests run. > 128.89s total testing time > > 7690 test cases (99%) succeeded > 1 test case (<1%) had incorrect layout > 3 test cases (<1%) had stderr output > > Full output: http://webkit-commit-queue.appspot.com/results/852028 It seems weird my patch will cause the failure of the above test case. Looks like bug 35594. I suspect the test is flakey. Comment on attachment 50601 [details]
fix patch
re-queueing
Comment on attachment 50601 [details] fix patch Clearing flags on attachment: 50601 Committed r56134: <http://trac.webkit.org/changeset/56134> All reviewed patches have been landed. Closing bug. |