Bug 36054

Summary:

Build warning : g_build_filename 's last element has to be NULL.

Product:

WebKit

Reporter:

Dominique Leuenberger <dominique-webkit.org>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch to fix the warnings.	darin: review-

Dominique Leuenberger

Reported 2010-03-12 06:50:05 PST

Created attachment 50592 [details] Patch to fix the warnings. gcc spits a warning regarding wrong usage of g_build_filename. The attached (trivial) patch fixes it. (I had the error in webkitgtk-1.1.23... checked SVN and it's the same for now).

Attachments
Patch to fix the warnings. (772 bytes, patch) 2010-03-12 06:50 PST, Dominique Leuenberger	darin: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2010-03-12 07:30:59 PST

Comment on attachment 50592 [details] Patch to fix the warnings. Patch looks great and was about to set review+, but can't set review+ on a patch without a change log, so review-.

Dominique Leuenberger

Comment 2 2010-03-12 07:42:13 PST

Darin, shall I respin an other one (checking our from svn, preparing all) or do you just want to commit a 'valid' fix as your self? (I mean the whole thing is really trivial).

Alberto Garcia

Comment 3 2013-09-09 09:23:29 PDT

Already fixed http://trac.webkit.org/changeset/59868

Note You need to log in before you can comment on or make changes to this bug.