Bug 36054

Summary: Build warning : g_build_filename 's last element has to be NULL.
Product: WebKit Reporter: Dominique Leuenberger <dominique-webkit.org>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch to fix the warnings. darin: review-

Description Dominique Leuenberger 2010-03-12 06:50:05 PST
Created attachment 50592 [details]
Patch to fix the warnings.

gcc spits a warning regarding wrong usage of g_build_filename.

The attached (trivial) patch fixes it.

(I had the error in webkitgtk-1.1.23... checked SVN and it's the same for now).
Comment 1 Darin Adler 2010-03-12 07:30:59 PST
Comment on attachment 50592 [details]
Patch to fix the warnings.

Patch looks great and was about to set review+, but can't set review+ on a patch without a change log, so review-.
Comment 2 Dominique Leuenberger 2010-03-12 07:42:13 PST
Darin, 

shall I respin an other one (checking our from svn, preparing all) or do you just want to commit a 'valid' fix as your self? (I mean the whole thing is really trivial).
Comment 3 Alberto Garcia 2013-09-09 09:23:29 PDT
Already fixed http://trac.webkit.org/changeset/59868