Summary: | PrintContext.end() not called from PrintContext::pageNumberForElement() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yuzo Fujishima <yuzo> | ||||||
Component: | Tools / Tests | Assignee: | Yuzo Fujishima <yuzo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hamaji, hayato, peter.linss, tkent | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Yuzo Fujishima
2010-03-11 22:51:06 PST
Created attachment 50578 [details]
Always call PrintContext.end() from PrintContext::pageNumberForElement().
Comment on attachment 50578 [details] Always call PrintContext.end() from PrintContext::pageNumberForElement(). Thanks for the nice catch! > + Always call PrintContext.end() from PrintContext::pageNumberForElement(). > + https://bugs.webkit.org/show_bug.cgi?id=36049 > + We usually write why we don't need new tests. Thank you for the review. I'll commit the change after fixing the Changelog. Created attachment 50685 [details]
Always call PrintContext.end() from PrintContext::pageNumberForElement().
I've added a test instead of changing the log. Can you take another look? Comment on attachment 50685 [details]
Always call PrintContext.end() from PrintContext::pageNumberForElement().
Looks good. It's unfortunate we cannot test this without images though.
Committed r55988: <http://trac.webkit.org/changeset/55988> |