Bug 36038

Summary: Add more test cases for Blob.slice
Product: WebKit Reporter: Jian Li <jianli>
Component: Layout and RenderingAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dimich
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch dimich: review+, jianli: commit-queue-

Jian Li
Reported 2010-03-11 15:55:10 PST
Need to add more test cases for Blob.slice, including empty file and big file.
Attachments
Proposed Patch (10.84 KB, patch)
2010-03-11 15:57 PST, Jian Li 		dimich: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-03-11 15:57:37 PST
Created attachment 50554 [details] Proposed Patch
Dmitry Titov
Comment 2 2010-03-11 17:19:31 PST
Comment on attachment 50554 [details] Proposed Patch r=me with a nit: > diff --git a/LayoutTests/http/tests/local/resources/send-sliced-dragged-file.js b/LayoutTests/http/tests/local/resources/send-sliced-dragged-file.js > function runTest() > + > + debug("Test slicing and sending a small file."); > + dragAndSliceStableFile("resources/file-for-drag-to-send.txt", 10, 2, 4); > + dragAndSliceStableFile("resources/file-for-drag-to-send.txt", 10, 2, 20); > + dragAndSliceStableFile("resources/file-for-drag-to-send.txt", 10, 15, 20); > + > + debug("Test slicing and sending a big file."); > + dragAndSliceStableFile("resources/abe.png", 12242, 10, 40); > + dragAndSliceStableFile("resources/abe.png", 12242, 10, 3000); > + dragAndSliceStableFile("resources/abe.png", 12242, 3000, 15000); It would be nice to add info on why this file size is enough... Also, enough for what? I think you are trying to hit the codepath where some buffer is getting full, it's good to mention it.
Jian Li
Comment 3 2010-03-11 18:17:01 PST
Committed as http://trac.webkit.org/changeset/55873.
Note You need to log in before you can comment on or make changes to this bug.