Bug 36021

Summary: support lang attribute on <option> elements
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, darin, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

chris fleizach
Reported 2010-03-11 10:42:42 PST
the lang attribute does not work on <option> elements because they don't have renderers and are not AccessibilityRenderObjects
Attachments
Patch (7.92 KB, patch)
2010-03-11 10:48 PST, chris fleizach 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2010-03-11 10:48:20 PST
Created attachment 50516 [details] Patch
Darin Adler
Comment 2 2010-03-11 11:00:10 PST
Comment on attachment 50516 [details] Patch > + String lang = getAttribute(node, langAttr); You can make this code slightly more efficient by making the type of "lang" be const AtomicString&. r=me
Darin Adler
Comment 3 2010-03-11 11:08:09 PST
Please land a version that does not break the GTK build.
chris fleizach
Comment 4 2010-03-11 11:24:21 PST
too late... working on a fix
Eric Seidel (no email)
Comment 5 2010-03-15 16:05:58 PDT
Should this still be open?
chris fleizach
Comment 6 2010-03-15 16:07:35 PDT
no fixed in http://trac.webkit.org/changeset/55848
Note You need to log in before you can comment on or make changes to this bug.