Bug 35978 – Tooltip text being sent even when hovering the same node

• Component: WebCore Misc.
• Status: UNCONFIRMED

[Lucas De Marchi]

Created attachment 50418 [details]
send tooltip text only when node changed

Tooltip text is being generated and sent to chrome even if node the mouse is hovering is always the same.
The attachment fix this problem by sending the text to chrome only when node is not the same.

[WebKit Review Bot]

Attachment 50418 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/page/EventHandler.cpp:1387:  Declaration has space between type name and * in Page *page  [whitespace/declaration] [3]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 50418 [details]
send tooltip text only when node changed

This is missing a ChangeLog and test.

r-.

[Lucas De Marchi]

What test do you want? The Changelog I can fix, but a test for this is not that easy.

The thing is we are passing up the tooltip updates, even if it's not needed. This can be checked looking at source code or, when implementing a port like gtk/efl/qt seeing that a lot of tooltip updates arrive and we have to discard them ourselves.