Bug 35973
Summary: | [Win] fast/multicol/hit-test-above-or-below.html fails | ||
---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | ahmad.saleem792, bfulgham, bweinstein, kadam, mitz, simon.fraser |
Priority: | P3 | Keywords: | LayoutTestFailure, Qt, QtTriaged |
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | Linux |
Csaba Osztrogonác
fast/multicol/hit-test-above-or-below.html is a new test introduced in http://trac.webkit.org/changeset/55546
result: http://build.webkit.org/results/Qt%20Linux%20Release/r55780%20%288339%29/results.html
diff:
-Character at 750, 275 is null as expected.
+FAIL: Character at 750, 275 is m. Expected null.
-Character at 750, 475 is null as expected.
+FAIL: Character at 750, 475 is m. Expected null.
I made some experiment to find what cause this differences. I
compared our pixel result to result of Leopard, they are same.
But the render tree dump is different:
- RenderBlock (anonymous) at (0,0) size 188x50
- RenderText {#text} at (0,0) size 150x50
- text run at (0,0) width 150: "123"
- RenderBlock {DIV} at (0,50) size 188x70 [bgcolor=#0000FF]
- RenderBlock (anonymous) at (0,120) size 188x100
- RenderText {#text} at (0,0) size 150x50
- text run at (0,0) width 150: "abc"
+ RenderBlock (anonymous) at (0,0) size 188x50
+ RenderText {#text} at (0,0) size 150x49
+ text run at (0,0) width 150: "123"
+ RenderBlock {DIV} at (0,50) size 188x70 [bgcolor=#0000FF]
+ RenderBlock (anonymous) at (0,120) size 188x100
+ RenderText {#text} at (0,0) size 150x49
+ text run at (0,0) width 150: "abc"
...
Only the height of lines differs, the expected is 50, but we got 49.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
Tomorrow I'm going to fix this bug.
I skipped this test until fix to make Qt bot green again: http://trac.webkit.org/changeset/55782
mitz
I wonder if this is due to the non-Mac text selection behavior some ports implement.
Brian Weinstein
This test fails on Windows as well (in the same way) - Skipped in r56634.
Ádám Kallai
Is Anybody working this bug? Now This test is working on Qt WK2, but still fails on Qt WK1.
Diff is here:
--- /home/kadam/webkit/WebKit/WebKitBuild/Release/layout-test-results/fast/multicol/hit-test-above-or-below-expected.txt
+++ /home/kadam/webkit/WebKit/WebKitBuild/Release/layout-test-results/fast/multicol/hit-test-above-or-below-actual.txt
@@ -11,9 +11,9 @@
Character at 150, 275 is d as expected.
Character at 350, 275 is j as expected.
Character at 550, 275 is m as expected.
-Character at 750, 275 is null as expected.
+FAIL: Character at 750, 275 is m. Expected null.
Character at 150, 475 is d as expected.
Character at 350, 475 is j as expected.
Character at 550, 475 is m as expected.
-Character at 750, 475 is null as expected.
+FAIL: Character at 750, 475 is m. Expected null.
Ádám Kallai
I added to Qt WK1 TestExpectations. (only)
Committed r131051: <http://trac.webkit.org/changeset/131051>
Jocelyn Turcotte
=== Bulk closing of Qt bugs ===
If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.
If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Brent Fulgham
This is still a failure for the Win port.
Ahmad Saleem
We don't have any platform specific expectation for this test and AppleWin port is gone.
So Marking this as 'RESOLVED CONFIGURATION CHANGED'.