Bug 35952 – [chromium] Mouse wheel events don't get propagated to plugins

• Component: Platform
• Status: RESOLVED FIXED

[John Abd-El-Malek]

WebPluginContainerImpl::handleEvent only handles keyboard and mouse events.  We'll need to pass in mouse wheel events as well for Pepper.

[John Abd-El-Malek]

Created attachment 50378 [details]
Proposed patch

[WebKit Review Bot]

Attachment 50378 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/WebPluginContainerImpl.cpp:386:  cursor_info is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[John Abd-El-Malek]

Created attachment 50380 [details]
Updated patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 50380 [details]
Updated patch

> Index: WebKit/chromium/src/WebInputEventConversion.cpp

> +WebMouseWheelEventBuilder::WebMouseWheelEventBuilder(const WebCore::ScrollView* view, const WebCore::WheelEvent& event)
...
> +    scrollByPage = event.granularity() == WebCore::WheelEvent::Page;

^^^ no need for WebCore:: prefix since there is a 'using namespace WebCore'
up above.

[John Abd-El-Malek]

Committed r55805: <http://trac.webkit.org/changeset/55805>