Bug 35944

Summary: Add an appengine app to host chromium layout test results
Product: WebKit Reporter: Victor Wang <victorw>
Component: Tools / TestsAssignee: Victor Wang <victorw>
Severity: Normal CC: abarth, commit-queue, dglazkov, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Description Flags
Proposed Patch
Fixed a CR in proposed patch
abarth: review-
Proposed patch none

Description Victor Wang 2010-03-09 14:18:40 PST
Add an appengine app to host layout test results (JSON) for chromium flakiness dashboard. The app could be used to host other test result files if needed.
Comment 1 Victor Wang 2010-03-09 14:24:26 PST
Created attachment 50348 [details]
Proposed Patch
Comment 2 WebKit Review Bot 2010-03-09 14:28:17 PST
Attachment 50348 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/Scripts/webkitpy/test_result_server/index.yaml:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 30 in 12 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Victor Wang 2010-03-09 14:39:42 PST
Created attachment 50351 [details]
Fixed a CR in proposed patch
Comment 4 Adam Barth 2010-03-12 08:49:53 PST
Comment on attachment 50351 [details]
Fixed a CR in proposed patch

This should go in a subdirectory of WebKitTools, analogous to QueueStatusServer, which is another of our AppEngine apps.

I'm not sure we want svn:executable or svn:eol-style set on these files.

+ class DeleteFile

This app looks wide open for anonymous folks on the interest to screw with out datastore.  Do we care?

Do we want some CSS to make this pretty?  We can do that in another patch.
Comment 5 Victor Wang 2010-03-12 14:15:45 PST
Created attachment 50632 [details]
Proposed patch

A couple of updates in new patch:
-. moved the appengine to WebKitTool
-. added CSS
-. removed svn:executable and svn:eol-style
-. added test type support
-. more blobstore upload redirect handling.

Eventually, we will add code to limit users who could update these files, for now, I would like to get a version in and start testing it.
Comment 6 Adam Barth 2010-03-13 01:48:01 PST
Comment on attachment 50632 [details]
Proposed patch

Okiedokes.  Theoretically we're supposed to keep our python to 80 cols, but we probably won't be able to enforce that until we get our automatic pep8 stye checker.
Comment 7 WebKit Commit Bot 2010-03-13 02:45:05 PST
Comment on attachment 50632 [details]
Proposed patch

Clearing flags on attachment: 50632

Committed r55960: <http://trac.webkit.org/changeset/55960>
Comment 8 WebKit Commit Bot 2010-03-13 02:45:11 PST
All reviewed patches have been landed.  Closing bug.