Summary: | Add an appengine app to host chromium layout test results | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Victor Wang <victorw> | ||||||||
Component: | Tools / Tests | Assignee: | Victor Wang <victorw> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue, dglazkov, eric, ojan, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Victor Wang
2010-03-09 14:18:40 PST
Created attachment 50348 [details]
Proposed Patch
Attachment 50348 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/Scripts/webkitpy/test_result_server/index.yaml:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 30 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 50351 [details]
Fixed a CR in proposed patch
Comment on attachment 50351 [details]
Fixed a CR in proposed patch
This should go in a subdirectory of WebKitTools, analogous to QueueStatusServer, which is another of our AppEngine apps.
I'm not sure we want svn:executable or svn:eol-style set on these files.
+ class DeleteFile
This app looks wide open for anonymous folks on the interest to screw with out datastore. Do we care?
Do we want some CSS to make this pretty? We can do that in another patch.
Created attachment 50632 [details]
Proposed patch
A couple of updates in new patch:
-. moved the appengine to WebKitTool
-. added CSS
-. removed svn:executable and svn:eol-style
-. added test type support
-. more blobstore upload redirect handling.
Eventually, we will add code to limit users who could update these files, for now, I would like to get a version in and start testing it.
Comment on attachment 50632 [details]
Proposed patch
Okiedokes. Theoretically we're supposed to keep our python to 80 cols, but we probably won't be able to enforce that until we get our automatic pep8 stye checker.
Comment on attachment 50632 [details] Proposed patch Clearing flags on attachment: 50632 Committed r55960: <http://trac.webkit.org/changeset/55960> All reviewed patches have been landed. Closing bug. |