Bug 35940

Summary: Remove unused SPI in WebPluginController.mm
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit APIAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
beidson: review-
Patch (v2)
none
Patch (v3) none

Brady Eidson
Reported 2010-03-09 12:59:36 PST
In WebPluginController.mm, I noticed: // For compatibility only. - (void)showURL:(NSURL *)URL inFrame:(NSString *)target { ... } I did some digging, and this method was left around to support an ANCIENT version of the java plug-in and is no longer needed. We should nuke it.
Attachments
Patch (1.07 KB, patch)
2010-03-11 11:20 PST, Andy Estes 		beidson: review-
DetailsFormatted DiffDiff
Patch (v2) (1.12 KB, patch)
2010-03-11 11:54 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (v3) (1.12 KB, patch)
2010-03-11 11:56 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2010-03-09 13:25:53 PST
http://trac.webkit.org/changeset/55742
Brady Eidson
Comment 2 2010-03-09 13:26:10 PST
(In reply to comment #1) > http://trac.webkit.org/changeset/55742 Disregard, put this in the wrong bug.
Andy Estes
Comment 3 2010-03-11 11:20:14 PST
Created attachment 50518 [details] Patch
Brady Eidson
Comment 4 2010-03-11 11:44:41 PST
Comment on attachment 50518 [details] Patch r+
Brady Eidson
Comment 5 2010-03-11 11:51:07 PST
Comment on attachment 50518 [details] Patch Actually to be a stickler - you should mention this bug in the ChangeLog.
Brady Eidson
Comment 6 2010-03-11 11:51:26 PST
(changed to r-)
Andy Estes
Comment 7 2010-03-11 11:54:50 PST
Created attachment 50523 [details] Patch (v2)
Andy Estes
Comment 8 2010-03-11 11:56:00 PST
Created attachment 50525 [details] Patch (v3) Tabs!
Brady Eidson
Comment 9 2010-03-11 11:59:09 PST
Comment on attachment 50525 [details] Patch (v3) r+
WebKit Commit Bot
Comment 10 2010-03-12 07:45:31 PST
Comment on attachment 50525 [details] Patch (v3) Clearing flags on attachment: 50525 Committed r55901: <http://trac.webkit.org/changeset/55901>
WebKit Commit Bot
Comment 11 2010-03-12 07:45:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.