| Summary: | Remove unused SPI in WebPluginController.mm | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
| Component: | WebKit API | Assignee: | Andy Estes <aestes> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aestes, commit-queue | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Mac | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
(In reply to comment #1) > http://trac.webkit.org/changeset/55742 Disregard, put this in the wrong bug. Created attachment 50518 [details]
Patch
Comment on attachment 50518 [details]
Patch
r+
Comment on attachment 50518 [details]
Patch
Actually to be a stickler - you should mention this bug in the ChangeLog.
(changed to r-) Created attachment 50523 [details]
Patch (v2)
Created attachment 50525 [details]
Patch (v3)
Tabs!
Comment on attachment 50525 [details]
Patch (v3)
r+
Comment on attachment 50525 [details] Patch (v3) Clearing flags on attachment: 50525 Committed r55901: <http://trac.webkit.org/changeset/55901> All reviewed patches have been landed. Closing bug. |
In WebPluginController.mm, I noticed: // For compatibility only. - (void)showURL:(NSURL *)URL inFrame:(NSString *)target { ... } I did some digging, and this method was left around to support an ANCIENT version of the java plug-in and is no longer needed. We should nuke it.