Summary: | [Qt] [ rubberstamp!] Fix if statement in Qt Launcher | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robert Hogan <robert> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | kenneth | ||||||
Priority: | P2 | Keywords: | Qt | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Robert Hogan
2010-03-08 14:02:40 PST
Created attachment 50245 [details]
Patch
Please follow the QtWebKit bug reporting guidelines when reporting bugs. See http://trac.webkit.org/wiki/QtWebKitBugs Specifically: - The 'QtWebKit' component should only be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit http://trac.webkit.org/wiki/QtWebKitBugs#Component - Add the keyword 'Qt' to signal that it's a Qt-related bug http://trac.webkit.org/wiki/QtWebKitBugs#Keywords Landed as http://trac.webkit.org/changeset/55791. void WebViewGraphicsBased::setFrameRateMeasurementEnabled(bool enabled) { - if (m_measureFps = enabled) { + if (m_measureFps == enabled) { m_lastConsultTime = m_startTime = QTime::currentTime(); m_updateTimer->start(); } else This patch is wrong and broke the feature of the launcher. It attributes enabled to m_messureFpt and then does the if check. This is the same as m_measureFps = enabled; if (m_measureFps)... Please revert this patch. Created attachment 50624 [details]
Updated Patch
Patch was incorrect as Kenneth pointed out. Make it more obvious that it's already right!
Comment on attachment 50245 [details]
Patch
Looks like this patch is obsolete.
Manually committed as: http://trac.webkit.org/changeset/55961 |