Bug 35871

Summary: [chromium] Remove deprecated second arg to IsStandard in KURLGoogle.cpp
Product: WebKit Reporter: Brett Wilson (Google) <brettw>
Component: PlatformAssignee: Brett Wilson (Google) <brettw>
Status: RESOLVED FIXED    
Severity: Trivial CC: abarth, darin, dglazkov, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
levin: review-
Fixed patch abarth: review+

Description Brett Wilson (Google) 2010-03-08 10:00:11 PST
url_util::IsStandard's second argument is now deprecated. The current version with the "length" is currently in for compat only, and I'm going to delete it.

The usage of this version of the function should be updated to only have two arguments.
Comment 1 Brett Wilson (Google) 2010-03-08 10:01:12 PST
Created attachment 50231 [details]
Patch
Comment 2 WebKit Review Bot 2010-03-08 11:13:42 PST
Attachment 50231 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/345997
Comment 3 David Levin 2010-03-08 15:19:39 PST
Comment on attachment 50231 [details]
Patch

Please fix the chromium build issue.
Comment 4 Brett Wilson (Google) 2010-03-09 11:31:05 PST
Created attachment 50332 [details]
Fixed patch

I didn't realize there was an extra DEPS I had to update to pull googleurl for the WebKit builder. This patch updates that to bring it in sync with Chrome.
Comment 5 WebKit Review Bot 2010-03-09 11:54:30 PST
Attachment 50332 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/475004
Comment 6 Brett Wilson (Google) 2010-03-09 12:27:03 PST
Does the WebKit review bot pull deps? It really looks like not from what I can tell, unless I'm doing it wrong.
Comment 7 Adam Barth 2010-03-09 12:50:51 PST
> Does the WebKit review bot pull deps?

No, it doesn't.  We should improve it to pull deps.
Comment 8 Brett Wilson (Google) 2010-03-11 10:38:21 PST
Fixed in r55846