Summary: | Web Inspector: Refactor Audits panel presentation layer. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, rik, timothy | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Pavel Feldman
2010-03-08 04:29:46 PST
Created attachment 50207 [details]
[IMAGE] Audit launcher panel.
Created attachment 50208 [details]
[IMAGE] Audits run results for CNN (default unexpanded view).
Created attachment 50209 [details]
[IMAGE] Hovercard demo results expanded.
Created attachment 50211 [details]
[PATCH] Proposed change.
Comment on attachment 50211 [details] [PATCH] Proposed change. > + summary.value = "The following domains only serve one resource each. If possible, avoid the extra DNS " + > + "lookups by serving these resources from existing domains."; Just make this be on one line. It will need to be later for i18n anyway. Is there a P1 bug about i18n? I worry we will have trouble finding all the strings later… I will work on an icon sometime today. (In reply to comment #5) > (From update of attachment 50211 [details]) > > + summary.value = "The following domains only serve one resource each. If possible, avoid the extra DNS " + > > + "lookups by serving these resources from existing domains."; > > Just make this be on one line. It will need to be later for i18n anyway. > Done. > Is there a P1 bug about i18n? I worry we will have trouble finding all the > strings later… Whenever we enable it, we should do P1. FYI: we are not localizing devtools in Chromium. Are you sure we need that for audits? > > I will work on an icon sometime today. (In reply to comment #6) > (In reply to comment #5) > > Is there a P1 bug about i18n? I worry we will have trouble finding all the > > strings later… > > Whenever we enable it, we should do P1. FYI: we are not localizing devtools in > Chromium. Are you sure we need that for audits? We localize the Web Inspector in Safari releases. If the Audits panel is enabled, it needs to be localizable. Or we will need to potentially disable it in Safari. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/AuditCategories.js M WebCore/inspector/front-end/AuditResultView.js M WebCore/inspector/front-end/AuditRules.js M WebCore/inspector/front-end/AuditsPanel.js M WebCore/inspector/front-end/Settings.js M WebCore/inspector/front-end/audits.css M WebCore/inspector/front-end/inspector.js Committed r55727 |