Bug 35848

Summary:

Remove inconsistent "Too few arguments" handling for window.atob() and window.btoa()

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
patch	mitz: review+

Sam Weinig

Reported 2010-03-07 17:16:10 PST

window.atob() and window.btoa() throw on too few arguments being passed which is inconsistent and unnecessary. We should convert it treat arguments not passed as undefined like we do for almost all other functions.

Attachments
patch (6.92 KB, patch) 2010-03-07 17:19 PST, Sam Weinig	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2010-03-07 17:19:22 PST

Created attachment 50181 [details] patch

mitz

Comment 2 2010-03-07 17:22:33 PST

Comment on attachment 50181 [details] patch > +>>>>>>> .r55629 I was instructed to ignore this, so r=me

Sam Weinig

Comment 3 2010-03-07 17:27:11 PST

Landed in r55637.

Note You need to log in before you can comment on or make changes to this bug.