iFrames set to display:none are Missing from frames array

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[David Wheeler]

* SUMMARY
iframes with their CSS set to "display:none" are not included in the frames
array but should be.

* STEPS TO REPRODUCE
1. open testcase
2. Note that it displays "1"
3. Edit testcase to remove 'style="display:none"'.
4. Reload testcase.
5. Note that it now displays "2".

* RESULTS
There are two iframes in the HTML, but only one appears in the frames array.

* EXPECTED RESULTS
Both iframes should appear in the frames array, even if one is set to
"display:none". Such is the case in Firefox.

[David Wheeler]

Created attachment 2410 [details]
Test Case

[Chris Petersen]

I see this issue on Safari 2.0 (v412) and TOT WebKit under 10.4.1(8B15). I have attached a screen shot of 
what is displayed under Safari 2.0 and Firefox 1.0.4.

[Chris Petersen]

Created attachment 2440 [details]
Screen shot of Safari rendering this test case

[Chris Petersen]

Created attachment 2441 [details]
Screen shot of Mac Firefox 1.0.4 rendering this test case

[David Kilzer (:ddkilzer)]

This bug may be related to (or the root cause of) Bug 6926 and Bug 7237.

[Alexey Proskuryakov]

*** Bug 8976 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 9277 has been marked as a duplicate of this bug. ***

[Eric Seidel (no email)]

Another manifestation of this caused me several hours of headaches on our site:

<div id="test">
  <iframe id="iframe" name="iframe" src=""></iframe>
  <form target="iframe">
    <input type="submit" onclick="document.getElementById('test').style.display='none'"/>
  </form>
</div>

[Eric Seidel (no email)]

The effect of the above code, is that instead of submitting the form in the iframe, the user is assaulted by a new window! :(

[Adele Peterson]

we don't actually create Frame objects for frame nodes that don't have renderers.  We probably need to start doing that so frame's with display:none get appended to the FrameTree.  Or we could find another way to use the FrameArray in JS without using the FrameTree.  I'm not entirely sure how well that would work though.

[Anders Carlsson]

Created attachment 9210 [details]
Patch

[Anders Carlsson]

Comment on attachment 9210 [details]
Patch

This introduces crashes

[Anders Carlsson]

Created attachment 9215 [details]
Better patch

[Anders Carlsson]

Created attachment 9216 [details]
Patch without tabs

[Maciej Stachowiak]

Comment on attachment 9216 [details]
Patch without tabs

r=me

[Anders Carlsson]

Committed in r15170

[David Wheeler]

Sweet, thanks for the fix. When should we look for a Safari release with this fix?

[David Kilzer (:ddkilzer)]

(In reply to comment #17)
> Sweet, thanks for the fix. When should we look for a Safari release with this
> fix?

Apple doesn't comment on unreleased software, but if I had to guess, it would be Mac OS X 10.5 (Leopard).  Note that I am not an Apple engineer, nor am I employed by Apple.

[David Wheeler]

Yeah, that was my guess, too. Pity if true.