Summary: | check-webkit-style: false positive for empty loop | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shinichiro Hamaji <hamaji> | ||||||
Component: | Tools / Tests | Assignee: | Shinichiro Hamaji <hamaji> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Shinichiro Hamaji
2010-03-03 22:01:56 PST
Created attachment 49984 [details]
Patch v1
Comment on attachment 49984 [details]
Patch v1
I'm not sure I understand. Why would one ever want if (foo) {}?
Can you point to the style guide as to where this is documented? Or maybe the tests just need to be changed to use for or while.
Created attachment 50080 [details]
Patch v2
> Can you point to the style guide as to where this is documented? Or maybe the
> tests just need to be changed to use for or while.
Oops! Yes, we need to use for or while to make the tests reasonable. Thanks for catching this.
Comment on attachment 50080 [details]
Patch v2
OK. "while (condition)" would still be better with a real example of a useful "condition", but this looks OK.
Attachment 50080 [details] was posted by a committer and has review+, assigning to Shinichiro Hamaji for commit.
Committed r55656: <http://trac.webkit.org/changeset/55656> |