Bug 35712

Summary:

setenv messages too noisy in running build-webkit

Product:

WebKit

Reporter:

Yuzo Fujishima <yuzo>

Component:

Tools / Tests

Assignee:

Yuzo Fujishima <yuzo>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

hamaji, hayato, mrowe, tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Remove setenv messages from build-webkit output.	none
Remove setenv messages from build-webkit output.	none
By default, suppress setenv messages from build-webkit/build-dumprendertree output.	eric: review-

Yuzo Fujishima

Reported 2010-03-03 18:26:01 PST

build-webkit script prints too many setenv messages to see more important information.

Attachments
Remove setenv messages from build-webkit output. (987 bytes, patch) 2010-03-03 18:28 PST, Yuzo Fujishima	no flags	Details Formatted Diff Diff
Remove setenv messages from build-webkit output. (995 bytes, patch) 2010-03-03 18:35 PST, Yuzo Fujishima	no flags	Details Formatted Diff Diff
By default, suppress setenv messages from build-webkit/build-dumprendertree output. (4.74 KB, patch) 2010-03-03 21:13 PST, Yuzo Fujishima	eric: review-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yuzo Fujishima

Comment 1 2010-03-03 18:28:37 PST

Created attachment 49974 [details] Remove setenv messages from build-webkit output.

Yuzo Fujishima

Comment 2 2010-03-03 18:35:03 PST

Created attachment 49975 [details] Remove setenv messages from build-webkit output.

Mark Rowe (bdash)

Comment 3 2010-03-03 20:05:40 PST

Comment on attachment 49975 [details] Remove setenv messages from build-webkit output. Please don’t do this. These message are necessary to track down certain classes of build errors.

Yuzo Fujishima

Comment 4 2010-03-03 21:13:29 PST

Created attachment 49981 [details] By default, suppress setenv messages from build-webkit/build-dumprendertree output.

Yuzo Fujishima

Comment 5 2010-03-03 21:16:22 PST

Hi, Mark, Thank you for the review. I understand sometimes the setenv messages are needed. But can I assume they are needed only occasionally? I'd like to propose to use --verbose flag to see setenv messages and suppress them by default. Can you review the revised patch?

Eric Seidel (no email)

Comment 6 2010-03-04 14:07:23 PST

Comment on attachment 49981 [details] By default, suppress setenv messages from build-webkit/build-dumprendertree output. Bleh. Yet another option hacked into build-webkit. We had this support at some point. Maybe some of the build scripts still do. The set envs are useless for most people, but I do think that the bots might still want them (or at least that's what Mark's comment implies). We also have a --quiet flag that we pass to run-webkit-tests which hides the build output from build-dumprendertree entirely if I remember correctly. So I like this change in principle. But I think we may need to change the buildbots to call build-* with --verbose to satisify mark's concerns. Also, it's sad that we continue to hack options in like this. Would be better if (like python) we had some sort of option dictionary that we just passed around to all these methods. r- because this woudl change buildbot behavior.

Yuzo Fujishima

Comment 7 2010-03-04 17:10:11 PST

Hi, Mark, Eric, Thank you for your reviews. OK, I gave up. I close this bug. Yuzo

Note You need to log in before you can comment on or make changes to this bug.