Bug 35695

Summary: Move files from WebCore/platform/graphics/gtk to ../cairo
Product: WebKit Reporter: Leandro Pereira <leandro>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, gustavo, rakuco, webkit.review.bot, zecke
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Attachments:
Description Flags
Move font code from platform/graphics/gtk to ../cairo
gustavo: review-
Move font code from platform/graphics/gtk to ../cairo none

Description Leandro Pereira 2010-03-03 12:22:34 PST 
Created attachment 49932 [details]
Move font code from platform/graphics/gtk to ../cairo

The attached patch moves files from WebCore/platform/graphics/gtk to WebCore/platform/graphics/cairo, since they're not really GTK+-dependent.

These files are (almost) identical to the ones used by the EFL port, so they can be shared (see bug #35539).
Comment 1 WebKit Review Bot 2010-03-03 12:23:52 PST 
Attachment 49932 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
[5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:102:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:106:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:119:  Use 0 instead of NULL.  [readability/null] [4]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:157:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:163:  Use 0 instead of NULL.  [readability/null] [4]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:258:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:259:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:48:  font_extents is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:49:  text_extents is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:101:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:126:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp"
WebCore/platform/graphics/cairo/FontCacheCairo.cpp:43:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontCacheCairo.cpp:48:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontCustomPlatformData.h:27:  cairo_font_face_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/cairo/FontCustomPlatformData.cpp:25:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontPlatformData.h"
WebCore/platform/graphics/cairo/FontPlatformData.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/graphics/cairo/FontPlatformData.h:104:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp"
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/SimpleFontDataGtk.cpp"
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontCustomPlatformData.cpp"
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontCacheGtk.cpp"
Total errors found: 20 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Gustavo Noronha (kov) 2010-03-03 12:48:54 PST 
Comment on attachment 49932 [details]
Move font code from platform/graphics/gtk to ../cairo

I think the move makes sense. I would like to have this change be done in two separate parts, though: one patch for the move, one patch for the efl-changes (adding the preprocessor conditionals, for instance). This will make it less likely that we are going to cause an issue we will have a hard time identifying.
Comment 3 Leandro Pereira 2010-03-03 13:24:00 PST 
Created attachment 49938 [details]
Move font code from platform/graphics/gtk to ../cairo

Updated patch, so it only move files around.
Comment 4 WebKit Review Bot 2010-03-03 13:25:48 PST 
Attachment 49938 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
 [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:99:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:103:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:115:  Use 0 instead of NULL.  [readability/null] [4]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:150:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:155:  Use 0 instead of NULL.  [readability/null] [4]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:247:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:248:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:48:  font_extents is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:49:  text_extents is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:101:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:126:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp"
WebCore/platform/graphics/cairo/FontCacheCairo.cpp:43:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontCacheCairo.cpp:48:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/cairo/FontCustomPlatformData.h:27:  cairo_font_face_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/cairo/FontCustomPlatformData.cpp:25:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontPlatformData.h"
WebCore/platform/graphics/cairo/FontPlatformData.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/graphics/cairo/FontPlatformData.h:104:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp"
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/SimpleFontDataGtk.cpp"
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontCustomPlatformData.cpp"
WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontCacheGtk.cpp"
Total errors found: 20 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Gustavo Noronha (kov) 2010-03-03 15:50:53 PST 
Comment on attachment 49938 [details]
Move font code from platform/graphics/gtk to ../cairo

OK, EWS seems happy.
Comment 6 WebKit Commit Bot 2010-03-04 00:51:21 PST 
Comment on attachment 49938 [details]
Move font code from platform/graphics/gtk to ../cairo

Clearing flags on attachment: 49938

Committed r55510: <http://trac.webkit.org/changeset/55510>
Comment 7 WebKit Commit Bot 2010-03-04 00:51:25 PST 
All reviewed patches have been landed.  Closing bug.