Bug 35692

Summary:

Crash when calling abort() on an XHR while in a windowless WebView

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebKit Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
proposed fix	timothy: review+, timothy: commit-queue-

Alexey Proskuryakov

Reported 2010-03-03 11:05:22 PST

-[WebAuthenticationPanel runAsModalDialogWithChallenge:] doesn't retain the challenge, unlike -[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]. But there is no real difference between these, because timers can fire behind either.

Attachments
proposed fix (1.72 KB, patch) 2010-03-03 11:08 PST, Alexey Proskuryakov	timothy: review+ timothy: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2010-03-03 11:05:58 PST

<rdar://problem/7703622>

Alexey Proskuryakov

Comment 2 2010-03-03 11:08:47 PST

Created attachment 49922 [details] proposed fix

Timothy Hatcher

Comment 3 2010-03-03 11:18:16 PST

Comment on attachment 49922 [details] proposed fix You have two ChangeLog entries.

Oliver Hunt

Comment 4 2010-03-03 11:21:05 PST

Comment on attachment 49922 [details] proposed fix can you use a retainptr for this instead of manual refcounting? kthxbai

Alexey Proskuryakov

Comment 5 2010-03-03 11:34:47 PST

Committed <http://trac.webkit.org/changeset/55470>. > can you use a retainptr for this instead of manual refcounting? kthxbai No, it's a .m file.

Note You need to log in before you can comment on or make changes to this bug.