Bug 35692

Summary:

Crash when calling abort() on an XHR while in a windowless WebView

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebKit Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
proposed fix	timothy: review+, timothy: commit-queue-

Description Alexey Proskuryakov 2010-03-03 11:05:22 PST

-[WebAuthenticationPanel runAsModalDialogWithChallenge:] doesn't retain the challenge, unlike -[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]. But there is no real difference between these, because timers can fire behind either.

Comment 1 Alexey Proskuryakov 2010-03-03 11:05:58 PST

<rdar://problem/7703622>

Comment 2 Alexey Proskuryakov 2010-03-03 11:08:47 PST

Created attachment 49922 [details]
proposed fix

Comment 3 Timothy Hatcher 2010-03-03 11:18:16 PST

Comment on attachment 49922 [details]
proposed fix

You have two ChangeLog entries.

Comment 4 Oliver Hunt 2010-03-03 11:21:05 PST

Comment on attachment 49922 [details]
proposed fix

can you use a retainptr for this instead of manual refcounting? kthxbai

Comment 5 Alexey Proskuryakov 2010-03-03 11:34:47 PST

Committed <http://trac.webkit.org/changeset/55470>.

> can you use a retainptr for this instead of manual refcounting? kthxbai

No, it's a .m file.