Bug 35686

Summary: Type=number UI part 3: Implement interactive behavior of spin-button
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on: 32813    
Bug Blocks: 27968, 38380    
Attachments:
Description Flags
Proposed patch (EWS failure expected) none

Kent Tamura
Reported 2010-03-03 07:47:13 PST
Make spin-buttons workable by user's click.
Attachments
Proposed patch (EWS failure expected) (19.36 KB, patch)
2010-03-03 07:48 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-03-03 07:48:09 PST
Created attachment 49908 [details] Proposed patch (EWS failure expected)
Kent Tamura
Comment 2 2010-03-03 07:49:09 PST
(In reply to comment #1) > Created an attachment (id=49908) [details] > Proposed patch (EWS failure expected) This depends on a patch in Bug#32813.
Adele Peterson
Comment 3 2010-04-14 22:14:45 PDT
Comment on attachment 49908 [details] Proposed patch (EWS failure expected) The general approach here looks good. I wish there were a better name for "stepUpFromRenderer". I don't have a good suggestion right now though. SpinUpState doesn't have any different visual effect right now, right? What will it do in the future?
Kent Tamura
Comment 4 2010-04-15 10:26:15 PDT
(In reply to comment #3) > (From update of attachment 49908 [details]) > The general approach here looks good. I wish there were a better name for > "stepUpFromRenderer". I don't have a good suggestion right now though. How about "stepUpForUI"? I also have no good idea. > SpinUpState doesn't have any different visual effect right now, right? Right. > What will it do in the future? I had had no idea. But I recently know the existence of HITheme API. Appearance.h has khemeStatePressedUp and kThemeStatePressedDown. I'll try to replace NSStepperCell with HITheme API after this patch is landed.
Kent Tamura
Comment 5 2010-04-30 01:49:33 PDT
Landed as r58564.
Note You need to log in before you can comment on or make changes to this bug.