Summary: | Google Analytics triggers "blocked plugin" UI | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, fishd, pkasting | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Adam Barth
2010-03-01 23:44:33 PST
Created attachment 49784 [details]
Patch
Comment on attachment 49784 [details] Patch Thanks for working on this! Just some minor issues: > +++ b/WebCore/loader/FrameLoader.cpp > + const bool allowed = m_client->allowPlugins(settings && settings->arePluginsEnabled()); nit: gratuitous const :) > +++ b/WebCore/loader/FrameLoader.h > @@ -82,6 +82,11 @@ class Widget; > struct FrameLoadRequest; > struct WindowFeatures; > > +enum ReasonForCallingAllowPlugins { > + AboutToInstantiatePlugin, > + NotAboutToInstantiatePlugin > +}; ^^^ maybe this should go in FrameLoaderTypes.h? > +++ b/WebCore/loader/MainResourceLoader.cpp ... > + if (!m_frame->loader()->allowPlugins(NowAboutToInstantiatePlugin)) NowAboutToInstantiatePlugin -> AboutToInstantiatePlugin, right? > +++ b/WebKit/chromium/public/WebFrameClient.h > + // Notifies the client that the frame would have instanitated a plug-in if plug-ins were enabled. instanitated -> instantiated Created attachment 49809 [details]
Patch
> nit: gratuitous const :) Removed. > ^^^ maybe this should go in FrameLoaderTypes.h? Done. > > +++ b/WebCore/loader/MainResourceLoader.cpp > ... > > + if (!m_frame->loader()->allowPlugins(NowAboutToInstantiatePlugin)) > > NowAboutToInstantiatePlugin -> AboutToInstantiatePlugin, right? "Now" is a typo. I think it's supposed to be "Not". > instanitated -> instantiated Fixed. Comment on attachment 49809 [details] Patch Clearing flags on attachment: 49809 Committed r55449: <http://trac.webkit.org/changeset/55449> All reviewed patches have been landed. Closing bug. |