Bug 35563

Summary: Refactor named getter function signature to be in line with indexing getter signature
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mjs: review+

Oliver Hunt
Reported 2010-03-01 23:34:10 PST
Refactor named getter function signature to be in line with indexing getter signature
Attachments
Patch (65.27 KB, patch)
2010-03-01 23:58 PST, Oliver Hunt 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-03-01 23:58:49 PST
Created attachment 49785 [details] Patch
WebKit Review Bot
Comment 2 2010-03-02 00:03:29 PST
Attachment 49785 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptGlue/UserObjectImp.cpp:117: Declaration has space between type name and * in UserObjectImp *thisObj [whitespace/declaration] [3] Total errors found: 1 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.
Maciej Stachowiak
Comment 3 2010-03-02 00:04:34 PST
Comment on attachment 49785 [details] Patch r=me
Oliver Hunt
Comment 4 2010-03-02 00:20:58 PST
Committed r55401: <http://trac.webkit.org/changeset/55401>
Note You need to log in before you can comment on or make changes to this bug.